On Wed, Jan 23, 2013 at 5:39 AM, Jakub Wilk wrote: > (I don't intend to sponsor this package, sorry.)
I am willing to sponsor it when it is ready. Since you are upstream, please read our upstream guide if you didn't already: http://wiki.debian.org/UpstreamGuide Please fix the issues Jakub Wilk and Juhani Numminen identified and these extra ones: .tar.gz in the watch file should be replaced with this, which will give maximum flexibility in case upstream tarballs change their names: \.(?:zip|tgz|tbz|txz|(?:tar\.(?:gz|bz2|xz))) You can drop all of the comments from debian/rules, they are not needed. Please add --parallel to the arguments of dh, this should speed up builds on multi-core/multi-CPU machines. Please come up with an icon for the program. Don't ship the upstream README, it doesn't add anything over the package description. I would suggest running wrap-and-sort -sa to make package diffs more readable. The actual upstream website seems to be a different one, dualword.org is just a frameset, but even that isn't a very useful homepage, so I would suggest just linking to the sourceforge page: http://sourceforge.net/projects/dualword/ Why is there a copy of debian/ in pkg/debian/? In dualword.desktop please swap in these lines. dualword could be installed in any part of PATH, not just /usr/bin. The icon name should be the same as the executable name. Exec=dualword Icon=dualword You can delete the comments from dualword.1, they aren't needed. The Xapian index in the index/ directory should be created from source at build time, as Jakub suggests. I would suggest deleting the empty ChangeLog from your SVN repository and automatically generating it with svn2cl when you build your tarballs. The message that pops up on first run is probably unnessecary, just copy the pre-built index when the per-user one is not found. The program started up with Russian, it might be better to start with the Settings tab open so that people can choose which language they want to learn. The package should probably recommend or suggest festival or whatever is needed to enable speech synthesis and the "turn speech on" setting should say what I need to install when it is not found. For bonus points you could even use the PackageKit APIs to allow users to install it automatically. Please note that packages from contrib/non-free should never be in Depends/Recommends of packages in main. The "Say" button should disappear or be disabled when there is no speech synthesis available. There isn't any feedback when you get a word wrong. I don't understand what the "I Know this one" button does, it probably needs a tooltip explaining it. The program doesn't remember which language I chose between restarts. The packages dict-freedict-spa-eng and dict-freedict-eng-spa might be useful for users wanting to look up the meaning of Spanish words, it would be useful to integrate looking up words in dictionaries. I'm not sure how to go about that but I guess Qt/KDE might have something for that. The Dictionary tab doesn't appear to work with foreign language words, I can search for English words but not Spanish ones. When I run two copies of dualword and then click on the Settings tab, the second copy segfaults. The word lists (at least for Spanish) appear to be quite limited. What is the process for adding new words? Would it be possible to use the wordlists from dict-freedict-spa-eng/dict-freedict-eng-spa or similar? In Debian we have an automated translation program called apertium and a few language pairs. I'm not sure how but perhaps its D-Bus interface could be useful in some way. Or you might simply wish to help to maintain it and the language pairs: http://www.apertium.org/ http://packages.debian.org/search?keywords=apertium http://packages.qa.debian.org/a/apertium.html Some automated checks from here: http://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package gcc: app/Index.cpp: In member function 'void Index::validate()': app/Index.cpp:105:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] lintian: W: dualword: hardening-no-fortify-functions usr/bin/dualword W: dualword source: out-of-date-standards-version 3.9.3 (current is 3.9.4) cme: Warning in 'control source Standards-Version' value '3.9.3': Current standards version is 3.9.4 suspicious-source: ./index/termlist.baseA ./index/termlist.baseB ./index/record.DB ./index/iamchert ./index/postlist.DB ./index/termlist.DB ./index/position.DB ./index/position.baseB ./index/postlist.baseA ./index/postlist.baseB ./index/record.baseB ./index/record.baseA ./index/position.baseA desktop-file-validate: ./pkg/dualword.desktop: error: value "text/plain" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAKTje6HXYM0NJJz1wW6e9n-Lh978oTBwC_3b3WP6F=dhnfc...@mail.gmail.com
