On Tue, Oct 30, 2012 at 6:18 PM, Kai Storbeck wrote: > I am looking for a sponsor for my package "roundup". I have a dedicated > uploader (Toni Mueller), but another eye on my changes needn't hurt. It > fixes 3 outstanding bugs, one of which is an RC bug.
Hi, I've just reviewed this. + * patch 13_rebuild_documentation.patch: + Include the upstream doc/conf.py to enable building the documentation + as html through sphinx instead of rst2html, and updated the README.txt + accordingly. + (Closes: #677976) I'm not particularly comfortable with the size of fixes applied for #677976. Also, it's only an important bug, so it doesn't necessarily need to go into this release. + * do not remove roundup user on purge, due to possible dataloss This sounds like a grave issue. If so, why is there no bug report about it? If you think this needs to be fixed for wheezy, please write a bug report with sufficient rc severity. + * cleanup postrm and postinstall to use #DEBHELPER# tags Are there currently consequences to this issue? If so, there should be a bug report, and only if that is rc severity would it need to be fixed in an update during the freeze. + * fix warning description-synopsis-starts-with-article This is cosmetic, so it shouldn't be done in the freeze. + * Rebuild documentation using python-sphinx during package creation + and use dh_sphinxdoc to fix all occurrences of common javascript libs. + Thanks to Jakub Wilk for reporting this bug. + (Closes: #678000) This is also only an important bug, and I don't think it needs to be fixed for wheezy at this point. So, anyway, if you can address these concerns and prepare a new package, I will review again and sponsor if it looks good. Best wishes, Mike -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CANTw=MP+QDZ2bcLDfjArm2wPAsKnW9kzBQJtk8=gdbn570h...@mail.gmail.com
