On Sep 5, 2012, at 03:09, Arno Töll <a...@debian.org> wrote: > tags 686679 + moreinfo > thanks > > Hi Eugene, > > On 04.09.2012 18:23, Eugene Seliverstov wrote: >> A package asn1c was previously maintained by W. Martin Borgert >> <deba...@debian.org> >> but it was removed from testing and unstable distributions due to lack of >> adopters. >> Current package is based on original package and includes several new patches >> to conform with latest Debian Policy. > > > this is a review of your package.
Hi, Arno, Thank you for the review! > > * Do not install Lintian overrides for manpage-has-errors-from-man. The > warning is legit, but of minor importance. Either fix it, or ignore it. > > * You are missing several uploads of asn1c which were in Debian at some > point after Squeeze's version. You can find the latest package in [1]. > Consequently your version number is too low. 0.9.21.dfsg-1 was in Debian > already in 2007 (uploaded 21 Jun 2007). Please use at very least > 0.9.21.dfsg-5. Moreover, please import the delta of changes since then > to your package. I have some questions about versioning scheme. Package is based on latest 0.9.21.dfsg-4 and includes all of these changes. But I reseted (maybe incorrectly) a numbering due to use '+dfsg' prefix instead of '.dfsg'. 1. Is it okay to use recommended '+dfsg' prefix? According to comparison rules 0.9.21+dfsg-5 is lesser than a 0.9.21.dfsg-4 and ever 0.9.21.dfsg-5. Should I keep .dfsg prefix? Does it matter that a package upload is a completely new and would not conflict with already removed asn1c? 2. In any case (.dfsg or +dfsg) '-5' debian version should be used, right? > > * There is a SVN repository for the packaging [2]. Please update that > and add it to your control file [3] > > * In debian/rules, please remove the boilerplate blind text. > > * At your choice, either document how to build a repacked tarball (you > need to remove the IETF files from the tarball as you probably know) in > debian/README.source [4] or make a get-orig-source [5] target (or both). > > * I couldn't find the source for the PDF files you install from doc/ > (the preferred form for modification that is). Please include it in your > source package, or remove it while repacking the tarball. > > * Please add a DEP-3 header to your patches [6]. Also consider sending > it upstream, unless you did already. > > * debian/copyright wrongly claims, the package would be subject to the > BSD-2-clause license. Actually it is 3-clause. > > > > [1] http://snapshot.debian.org/package/asn1c/0.9.21.dfsg-4/ > [2] http://anonscm.debian.org/viewvc/collab-maint/deb-maint/asn1c/ > [3] > http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-vcs > [4] http://www.debian.org/doc/debian-policy/ch-source.html#s-readmesource > [5] http://www.debian.org/doc/debian-policy/ch-source.html#s-debianrules > [6] http://dep.debian.net/deps/dep3/ > -- > with kind regards, > Arno Töll > IRC: daemonkeeper on Freenode/OFTC > GnuPG Key-ID: 0x9D80F36D > --- Best regards, Eugene Seliverstov -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/80a58a04-2405-40c0-aea3-192d59910...@gmail.com
