On Wed, 2012-08-08 at 18:20 -0400, Raphael Hertzog wrote:
> Hi,
>
> On Mon, 06 Aug 2012, Robert James Clay wrote:
> > Besides uploading the new package version to the Mentors site, I went
> > ahead & submitted a Request for Sponsor bug as well (#684106 [1])
>
> Here's my review of your package:
I'll be working on these issues tomorrow.
>
> In control: ....
> This change is not documented in debian/changelog. Why did you remove
> those recommendations/suggestions ?
That may have been the result of merge issues from 1.3.18-2 back in
to what was then for 1.3.19-1, which I thought I had taken care of.
I'll check it.
> In preinst:
>
> +# Set old_version variable for use later in the script.
> +old_version=$2
> You do not seem to use $old_version later. Drop it.
I'll check that as well, as I thought I had a need for it (& it
should therefore still be used)...
RJ Clay
j...@rocasa.us
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/1344470443.9544.23.camel@svrpc
