severity 678992 wishlist thanks Hi José,
José Luis Segura Lucas wrote: > I am looking for a sponsor for my package "grive" > > * Package name : grive > Version : 0.1.1+20120619git27g55c0f4e-1 > Upstream Author : Matchman Green <match...@gmail.com> and Nestal Wan > <m...@nestal.net> > * URL : http://www.lbreda.com/grive > * License : GPLv2 > Section : net > > It builds those binary packages: > > grive - Google Drive client for GNU/Linux I took a look at your package: - Since you're packaging a snapshot version, you should adjust your watch file accordingly: Processing watchfile line for package grive... Newest version on remote site is 0.1.1, local version is 0.1.1+20120619git27g55c0f4e grive: remote site does not even have current version - It seems like all the source files of Grive are released under the GPL-2, and not GPL-2+ (according to the license headers in those files). You should correct that in debian/copyright, and using the same formulation as in the license headers seems like a good idea. The license for the debian/* files is said to be GPL-2+, but in the license paragraph it refers to the GPL-3. I couldn't find Matchman Green's name in any of the source files; are you sure they're one of the copyright holders? - debian/README.Debian should be debian/README.source, although I would argue it doesn't contain any useful information at the moment. - In debian/control, the Vcs-Git field is intended for the packaging, not the upstream repository; if you don't have a public git repository for the Debian packaging, remove that line. The long description could be improved; please have a look at [1]. [1] http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-pkg-desc Please run wrap-and-sort from the devscripts package to have the Build-Depends field wrapped and sorted (and use ">= 9" for debhelper). - Why do you override the hardening-no-fortify-functions lintian warning? If you have a good reason to do so, you should explain it in a comment in debian/grive.lintian-overrides. - Grive includes a test suite, but it isn't built nor run. - In the grive(1) man page, you should end each item in the DESCRIPTION with punctuation. Mentioning that Grive is "for GNU/Linux systems" doesn't seem very useful; the person reading the man page is most likely doing so from such a system already. Grive shouldn't be italicized (.I) in the DESCRIPTION. Please consider removing the AUTHOR section (see man-pages(7) for details). Also, the REPORT BUGS section should be called BUGS, but I think it should be removed too, as Debian users should use the Debian BTS anyway. Cheers, -- Benoît Knecht -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120626153625.gc6...@marvin.lan
