On Fri, Jun 22, 2012 at 03:07:43AM +0300, Boris Pek wrote:
> I am looking for a sponsor for my package "sgml-data".

You say "QA upload" below, I guess you don't mean to adopt the package,
right?

Thanks for taking care of this package. This upload fixes at least one
RC bug.

>   http://mentors.debian.net/debian/pool/main/s/sgml-data/sgml-data_2.0.7.dsc

Your upload already fixes a lot of things, but there is still room for
improvement.

 * How about using dh_testdir instead of a custom $(checkdir)?
 * How about using dh_testroot instead of a custom $(checkroot)?
 * You could also replace some of the $(makedir) with dh_installdirs.
 * dh_clean removes *~, so there is no need to do this with find.
 * You no longer need to rmdir /etc/sgml on purge, cause there is a
   conffile in that directory.
 * The description still contains the homepage.

All of these problems are minor, so I would like to see this (or an
improved version) uploaded before the freeze. If this doesn't happen, I
will need someone to sponsor a NMU and a get a freeze exception which
means more work for the release team.

Thanks

Helmut



-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120623105744.ga19...@alf.mars

Reply via email to