Hi Philip, Philipp Hartwig wrote: > thank you very much for your comments.
Thanks for the feedback. > > a few observations (without having gone too deep yet, so I might have > > overseen > > some reasoning): > > > > notion_3+2012042300.orig.tar.gz from your package and > > notion-3-2012042300-src.tar.gz from SF seem to differ: > > > > 0ffd57a75f2c1a75ce551b3baef1fee0 notion_3+2012042300.orig.tar.gz > > 96d004374e92e3188608a39afea2d75f notion-3-2012042300-src.tar.gz > > > > -rw-r--r-- 1 abe tar 754121 May 16 15:29 notion_3+2012042300.orig.tar.gz > > -rw-r--r-- 1 abe tar 762655 Apr 23 18:42 notion-3-2012042300-src.tar.gz > > > > Is this on purpose? > > The files in the two archives are the same according to a recursive md5sum, > only the parent directories are called differently (we use 3-... as an > upstream version, which we change to 3+... when importing into the Debian git > repository to comply with [1]) and some file status information differs > (maybe/probably for the same reason). That's ok. I prefer to use tar balls identical to upstream whereever possible, but there also seem to be people in Debian which prefer the ease of creating tar balls directly out of the git repo which then always have these issues... > > The upstream ChangeLog says "(The ChangeLog will be generated by > > release scripts from svn logs)" -- looks like packaging a VCS > > snapshot. But the version suggests that an official upstream release > > and not a snapshot is packaged. Also such a ChangeLog stub should IMHO > > not show up in the Debian package as it's useless. > > Arnout has dropped the changelog, thanks. Good. > > [hardening flags] > > We have enabled hardening flags through a Debian patch to the build system. A > few Lintian warnings remain, but according to a discussion in > #debian-mentors, > these are false positives. Yeah, that's fine, too. As I discussed quite some stuff about the sponsoring of notion with Arnout on IRC, here's a list of what I consider as still open (with regards to the package on http://mentors.debian.net/package/notion from 2012-05-27 11:34Z): It looks mostly fine, but I'd like the following fixed: * debian/copyright seems to miss the copyright holders from the contrib directory; * For libtu/snprintf_2.2/snprintf.c I'd add the copyright holder and years to the note that this implementation is not used in the binary packages; * de/fontset.c has some more Copyright holders than mentioned in debian/copyright and the license seems to be different than what is mentioned in debian/copyright; * and more of these type of things. Please check that all persons which show up in the output of the following output are also mentioned in debian/copyright: egrep -i ' \(c\)|copyright' -r . | egrep -v 'debian|/LICENSE|Tuomo Valkonen' I know debian/copyright is already quite lengthy, but basically everything in the source package should also be mentioned in the debian/copyright package as it's at least redistributed via the Debian mirrors. Regards, Axel -- ,''`. | Axel Beckert <a...@debian.org>, http://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE `- | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120605112748.gh7...@sym.noone.org
