* Jonathan McCrohan <jmccro...@gmail.com>, 2012-06-02, 19:27:
I would add -x/--line-regexp to the fgrep call.
Wouldn't it be nice if the postinst also take care of the case when
the user enabled the service?
Couldn't both of these issues be addressed by removing '#<off># ' from
the grep?
I think we do need -x (or an equivalent of it). If the user appended
some options to nyancat-server command-line, we must not remove such
entry.
BTW, shouldn't you use --pattern (instead of, or maybe in addition to,
--multi)?
--
Jakub Wilk
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120602185957.ga2...@jwilk.net
