On 05/15/2012 09:29 AM, David Weber wrote: > Hi, > > I'm currently working on a sanlock[1] package for Debian. My current > attempts work good so far but some parts in the build process are > rather complicated (no ./configure; have to run make twice) so I > guess somebody more experienced should do a deeper review before > I can send a RFS. > > You can find my latest package here: > http://mentors.debian.net/package/sanlock > > Thanks! > > David > > > [1] https://fedorahosted.org/sanlock/
I'm far from being an expert (or a DD, for that matter), but I think you can simplify your build by using a patch that provides the top-level Makefile that is missing. E.g.: > --- /dev/null 1970-01-01 00:00:00.000000000 +0000 > +++ sanlock-2.2/Makefile 2012-05-15 15:38:59.833362732 +0200 > @@ -0,0 +1,3 @@ > +clean all install: > + $(MAKE) -C wdmd $@ > + $(MAKE) -C src $@ Then you can simplify the debian/rules to: > #!/usr/bin/make -f > > DEB_BUILDDIR := $(CURDIR)/debian/build > > override_dh_makeshlibs: > dh_makeshlibs -X/usr/lib/sanlock > > override_dh_installinit: > dh_installinit -psanlock --name=wdmd --no-restart-on-upgrade > dh_installinit -psanlock --name=sanlock --no-restart-on-upgrade > > %: > dh $@ Also, you should possibly patch those spelling errors in ./src/paxos_lease.c that lintian warns about (s/commited/committed/g). HTH Michael -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4fb25f82.7000...@users.sourceforge.net
