Oke , Fixed the isues and uploaded a new version
WIth kind regards, Bas -----Oorspronkelijk bericht----- Van: Arno Töll [mailto:a...@debian.org] Verzonden: vrijdag 20 april 2012 23:40 Aan: 669...@bugs.debian.org CC: Bas van den Dikkenberg Onderwerp: Bug#669609: sponsorship-requests: NMU mod-gnutls/0.5.10-1.1 Hi, now, that you've updated your package I finally reviewed it. These are my comments: * Do not set urgency=high. There is no point in doing so unless you fix a critical security issue. * There is an invalid changelog.dch file left over. Please remove it. * Do not modify previous changelog entries, especially not in NMUs. I mean this hunk: mod-gnutls (0.5.10-1) unstable; urgency=low * New upstream release (Closes: #602957) - -- Jack Bates <ms...@freezone.co.uk> Tue, 19 Jul 2011 09:38:29 -0700 + -- Jack Bates <ms...@freezone.co.uk> Tue, 19 Jul 2011 09:38:29 -0700 + * It's acceptable to update the DEP-5 URL since you are going to work on the package anyway. However, mention this in your changelog. * In the default-tls file, please remove extra white spaces (line 1, line 4, line 41 and line 42) * Remove the /doc alias and associated configuration from the default-tls file. See DSA 2452-1 for more background on that * Do not hard code the error log path in the very same file. Instead use ${APACHE_LOG_DIR} as a prefix. Likewise for the access.log. -- with kind regards, Arno Töll IRC: daemonkeeper on Freenode/OFTC GnuPG Key-ID: 0x9D80F36D -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/9345AD5DE363814DA41482800A8D50644209736C@srv02.dikkenberg.local
