tag 664766 + moreinfo confirmed
Hi,
sorry for taking a while, but here is the first round of comments:
"Stephen M. Webb" <stephen.w...@bregmasoft.ca> writes:
> ember (0.6.2-1) unstable; urgency=low
>
> * new upstream release (closes: #633854)
> - removed dependency on libceguiogre-dev (closes: #629767)
> * removed old unused build dependencies
> * converted to 3.0 (quilt) source format, removed obsolete patches
> * converted to use dh sequencer
> * new maintainer: Debian games team (closes: #653970)
> -added myself as uploader
^^^
There is a space missing here.
> * adjusted paths in installed launcher script to use defaults
> * used xz compression in packaging
> * debian/control: updated Standards-Version to 3.9.3
> * debian/copyright: changed to computer-readable format (DEP-5)
Comments about the packaging:
Looks good, only some minor nitpicks:
- debian/ember.1: "Debian GNU/Linux" should be changed to just "Debian".
- Are the patches forwarded upstream?
- d/rules: "find -exec rm" can be replaced with "find -delete"
- d/rules: "find ." could be replaced with "find debian/tmp" as I
understand you only want to remove duplicate COPYING files.
- d/rules: "# force use of local version of tolua++ and newer libtool"
doesn't seem related to the command below it.
About copyright information:
- src/components/ogre/environment/pagedgeometry/include/MersenneTwister.h:
BSD-*3*-clause, also:
"When you use this, send an email to: m-...@math.sci.hiroshima-u.ac.jp
with an appropriate reference to your work."
This additional clause makes the license non-free ("postcardware"),
see also the first example in question 12 of the [DFSGFAQ].
I believe having seeing this before and it might have changed by
upstream, but I haven't checked.
- FastDelegate.h: released under CPOL according to [FASTDELEGATE].
See [CPOL] for the license. I haven't read the license text yet,
please check it fulfills the DFSG requirements and is compatible with
the other licenses.
- DRGNURBSSurface.{h,cpp}: Copyright 1999 Intel Corporation.
See file for license.
- EmberPagingSceneManager/*: mostly LGPL-2+, not -2.1+
There are additional copyright holders and years of copyright should
probably be updated as well. I noticed at least these, but didn't look
that careful:
- years of copyright need to be updated:
Erik Hjortsberg <erik.hjortsb...@gmail.com>, (C) 2011
(from EmberPagingTerrainObserver.h and others)
- "Copyright (C) 2009 Manuel A. Fernandez Montecelo"
- "Copyright (C) 2011 Erik Ogenvik" GPL-2+
- src/components/ogre/gui/RenderedColourStringTextComponent.cpp:
"contains code lifted from the CEGUI project". Has additional
copyright holder and license.
- "Copyright (c) 2000-2006 Torus Knot Software Ltd"
About upstream code:
- ./ember should probably use `set -e' and maybe also `set -u'.
Also it's not possible to pass both --home and --debug.
- ./ember.in seems to be no longer needed (it has the same contents as
./ember).
- src/components/ogre/terrain/ICompilerTechniqueProvider.h:
The header states "C++ Interface: ITerrainMaterialFinalizer" which
looks like a copy-and-paste error. The include guards use
EMBER_OGREVIEW_ITERRAINMATERIALFINALIZER_H as well.
- spelling error: "To switch bach to attached mode, close the frame
window with the dialog": bach -> back
Regards,
Ansgar
[CPOL] <http://www.codeproject.com/info/cpol10.aspx>
[DFSGFAQ] <http://people.debian.org/~bap/dfsg-faq.html>
[FASTDELEGATE] <http://www.codeproject.com/cpp/FastDelegate.asp>
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/87hawtas9v....@deep-thought.43-1.org
