Hi, I'm not a DD so I can't sponsor your package, but I would be using this
package if it was in the archive. Thanks for packaging it. A few points about
the package:
* You don't need the substvar ${shlibs:Depends} in the control file for the
binary packages, since they are not compiled code. This gives a warning
currently.
* Why is the package priority extra? It should probably be optional.
* Consider switching off DH_VERBOSE in debian/rules before release, or at least
remove the comment above it.
* The translations seem to be being compiled twice, once during dh_auto_build
and once during dh_auto_install. This is probably unnecessary.
* You may want to Recommend or Suggest the 'vorbisgain' and 'mp3gain' package,
if rubyripper can use them. The same goes for 'normalize' but this may
require a patch, since Debian uses the name 'normalize-audio' for this
command. These were mentioned by the configure script.
* Grepping the source it seems that rubyripper can also use 'cdrdao' and 'sox'
for certain things -- consider the same for them.
* Consider changing your DEP-5 format URL now that this has become official.
<http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/>
* Do you need to patch the prefix '/usr' into the configure script? It seems
you already specify the /usr prefix by an override in debian/rules anyway, so
that seems redundant.
* You might consider splitting your patch into multiple patches, which would
allow you to give a more detailed rationale for each change. For instance,
your patch removes some code from the configure script probably to solve some
build issue, but the patch header doesn't explain this.
* Since you use the same man page for both rrip_cli and rrip_gui, you may want
to remove "(command-line interface)" from the NAME section of the manual
page.
Minor bugs that should probably be fixed by upstream:
* Consider fixing the example copyright headers on the .po files, they have
pasted in boilerplate.
* I get this message when running configure:
"'gettext/utils.rb' is deprecated. Use gettext/tools.rb."
* Many translations are generating warnings like:
- "Obsolete msgid exists"
- "Fuzzy message was ignored"
Thanks for your work! I will certainly be using this when it is uploaded.
Cheers,
David
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/caobnz7yeup9ko8istrg1zbdjl-x6igcs_-zk1w-p0m+kaza...@mail.gmail.com
