tag 658713 + confirmed thanks Hi,
andrei karas <aka...@inbox.ru> writes: > ManaPlus is client for Evol Online MMORPG and advanced client for The > Mana World. ManaPlus most used client in both this games. I probably won't have time to upload the package, but I did take a brief look at the Debian packaging where I found some (small) issues: The ttf-* packages seem to have been replaced by fonts-* packages in unstable. The ttf-* packages are now only transistional packages. The formatting of the package description looks strange with a new line started at the end of every sentence. debian/rules: If you copy files to debian/, you should remove them in the clean target as well. But as the .menu file is Debian-specific, it might be better to move it from the upstream source to debian/ anyway. Or install it directly to the right location instead of copying it to debian/ just so that dh_installmenu can find it. debian/rules: $(MAKE) install DESTDIR=$(CURDIR)/debian/tmp can probably just be dh_auto_install. Together with the previous change you could drop this override target. debian/rules: 'dh_installchangelogs ChangeLog' should no longer be needed if you use debhelper compat level >= 8. I would use 'dh_auto_configure -- --bindir=/usr/games' instead of calling ./configure directly as debhelper passes additional options to it. debian/rules: '[ ! -f Makefile ] || $(MAKE) distclean', dh_auto_clean should do that, no need to override it. Personally I prefer using 'dh $@ --with autoreconf' over adding the overrides by hand. Regards, Ansgar -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87vcnk6skx....@deep-thought.43-1.org
