On Sun, Nov 27, 2011 at 7:06 PM, David Kalnischkies <kalnischk...@gmail.com> wrote: > On Sun, Nov 27, 2011 at 12:56, Kartik Mistry <kartik.mis...@gmail.com> wrote: >> 1. gcc warnings: >> >> CC dwm.c >> dwm.c:882:1: warning: ‘focusmon’ defined but not used [-Wunused-function] > [… a few more of those … ] >> >> Send this to upstream, if you haven't. > > He is building two flavors, one without (a lot of) keybindings, so all these > functions aren't used by this flavor (web), but by the default one. > > So this fells like a pretty hard thing to fix… I would suggest adding a > -Wno-unused-function to non-default flavor builds instead.
Appending this will also be bit difficult because we won't be sure which config is not using these function. I think its better leave it as is than adding this flag blindly to all configs. What do you suggest? > >> 2. dpkg-buildflags.patch needs Patch header/description >> >> 3. Optionally, Patch 1 need description wrapped to 80 chars. > > Beside that, the git repo includes the .pc directory from quilt. > I don't think that this is a particular good idea… I didn't read why .pc directory is created and simply added it to git. Now removed that :) > > And as you try to follow DEP3 for the patches, add to both patches: > Forwarded: not-needed > It would be a shame to let these patches show up in a "untagged patches > which might need to be send upstream" report somebody hopefully works on. :) Done. Best Regards -- Vasudev Kamath http://vasudevkamath.blogspot.com http://twitter.com/vasudevkamath -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAK+NOPV-QHSjutUKFw1TaP_b�_bmdfhxwcclwo_tl4ccf...@mail.gmail.com
