As promised, here is my review. > I am looking for a sponsor for my package "eviacam". > > * Package name : eviacam > Version : 1.5.2 > Upstream Author : Cesar Mauri <ce...@crea-si.com> > * URL : http://viacam.org > * License : GPL
Version 3 or higher according to your copyright file.
> Section : x11
>
> It builds these binary packages:
> eviacam - A cross platform webcam based mouse emulator
For Debian it is not relevant that this software is cross platform. Also
the synopsis should not start with "A". I would suggest:
eviacom - webcam based mouse emulator
> I was able to fix most Lintian errors and warnings, but I feel that to
> fix the remaining warnings I would need some help.
>
> W: eviacam source: non-native-package-with-native-version
This should be solved by adding a DEBIAN version to the version number
in your changelog. I.e. 1.5.2-1.
> W: eviacam source: empty-debian-diff
This is because your upstream package already includes the debian
directory and there are no changes to be put in the diff and you are
using source 1.0 (implicit). If you want to continue also distributing
the debian directory in the upstream release I strongly suggest using
source version 3.0 (quilt) to avoid problems with NMU's. See also
dpkg-source(1).
> Please, answer me in CC.
Done.
Further, my comments on your debian/* files:
changelog
- As mentioned above, include the Debian version in the first line
- Close your ITP bug in the first entry like so:
* Initial release (closes: #634840 )
- Please update the time stamp to something more appropriate
changelog.in
- Not sure if this will be useful in the future. You will most likely
be editing the changelog manually (with the help of dch)
compat
- I believe ideas about which version should be used for new packages
varies from sponsor to sponsor, but 7 or 8 is most common nowadays. Of
course this influences your build dependencies.
control
- Your standards version is very old. The current version is 3.9.2.
Check what you need to change, and update accordingly.
- Any reason for not having priority "optional"?
- Consider putting your Debian packaging in a VCS and add the
appropriate tags
- I don't think it is appropriate to mention the website in the
description. The "Homepage" field is made for this purpose.
- As mentioned above, improve the short description
- I am no native speaker but I believe "a software" is rather strange.
If you want to improve the description you could ask on
debian-l10n-engl...@lists.debian.org
- I don't have understanding of wx2, but do your recommends work, i.e.
does the package find the right version, depending on the development
package used in the build-depends?
copyright
- Not mandatory, but quite some sponsors want it: consider to change
your copyright file to the DEP5 format [1].
- Please link to the versioned GPL in common-licenses.
- You did not include the copyright information of all the files. The
copyright file MUST list all the copyright holders and all licenses
of ALL files in your project.
dirs
- I don't think you need this with this content.
docs
- NEWS is empty, don't install it.
- Why install README.ca and not README.es?
rules
- I find the clean target a little strange, why copy the config.sub and
config.guess there?
- Clean up commented lines
- Not sure, but I think quite some options in your ./configure line are
added by the builder automatically.
Further comments:
Please include a watch file.
Your package is newer than the latest upstream release. As you are
upstream yourself, why didn't you create this new release yet?
The package FTBFS (fails to build from sourse) with the following error:
configure: error: Couldn't find linux/videodev.h nor libv4l1-videodev.h
Adding libv4l-dev to the build-depends helps to start building the
package. It would help to build your own packages in a clean environment
to check against such problems (and build in sid as well). Tools such as
pbuilder can help you there.
With libv4l-dev, it still FTBFS with the output as found below. The
complete output can be found here [2] (for a month).
Hope this helps to improve the package.
Paul
[1] http://dep.debian.net/deps/dep5/
[2] http://pastebin.com/FZStE1TJ
Making all in wxutil
make[3]: Entering directory `/tmp/buildd/eviacam-1.5.2/wxutil'
/bin/bash ../libtool --tag=CXX --mode=compile i486-linux-gnu-g++
-DHAVE_CONFIG_H -I. -I.. -Wall -fexceptions -Wconversion
-I/usr/lib/wx/include/gtk2-unicode-release-2.6 -I/usr/include/wx-2.6
-DGTK_NO_CHECK_CASTS -D__WXGTK__ -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES
-DNO_GCC_PRAGMA -I/usr/include/opencv -pthread -I/usr/include/atk-1.0
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pixman-1
-I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gtk-2.0
-I/usr/lib/gtk-2.0/include -I/usr/include/cairo -I/usr/include/pango-1.0
-I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -DNDEBUG -O2 -Wall -fexceptions
-Wconversion -I/usr/lib/wx/include/gtk2-unicode-release-2.6
-I/usr/include/wx-2.6 -DGTK_NO_CHECK_CASTS -D__WXGTK__
-D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -DNO_GCC_PRAGMA
-I/usr/include/opencv -pthread -I/usr/include/atk-1.0
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pixman-1
-I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gtk-2.0
-I/usr/lib/gtk-2.0/include -I/usr/include/cairo -I/usr/include/pango-1.0
-I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -DNDEBUG -O2 -MT wxappbar.lo -MD -MP -MF
.deps/wxappbar.Tpo -c -o wxappbar.lo wxappbar.cpp
mkdir .libs
i486-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I.. -Wall -fexceptions
-Wconversion -I/usr/lib/wx/include/gtk2-unicode-release-2.6
-I/usr/include/wx-2.6 -DGTK_NO_CHECK_CASTS -D__WXGTK__
-D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -DNO_GCC_PRAGMA
-I/usr/include/opencv -pthread -I/usr/include/atk-1.0
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pixman-1
-I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gtk-2.0
-I/usr/lib/gtk-2.0/include -I/usr/include/cairo -I/usr/include/pango-1.0
-I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -DNDEBUG -O2 -Wall -fexceptions -Wconversion
-I/usr/lib/wx/include/gtk2-unicode-release-2.6 -I/usr/include/wx-2.6
-DGTK_NO_CHECK_CASTS -D__WXGTK__ -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES
-DNO_GCC_PRAGMA -I/usr/include/opencv -pthread -I/usr/include/atk-1.0
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pixman-1
-I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gtk-2.0
-I/usr/lib/gtk-2.0/include -I/usr/include/cairo -I/usr/include/pango-1.0
-I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -DNDEBUG -O2 -MT wxappbar.lo -MD -MP -MF
.deps/wxappbar.Tpo -c wxappbar.cpp -fPIC -DPIC -o .libs/wxappbar.o
In file included from /usr/include/wx-2.6/wx/timer.h:25:0,
from wxappbar.h:30,
from wxappbar.cpp:30:
/usr/include/wx-2.6/wx/longlong.h: In member function 'double
wxLongLongNative::ToDouble() const':
/usr/include/wx-2.6/wx/longlong.h:169:38: warning: conversion to
'double' from 'long long int' may alter its value [-Wconversion]
wxappbar.cpp: In member function 'void WXAppBar::OnSize(wxSizeEvent&)':
wxappbar.cpp:449:9: warning: variable 's' set but not used
[-Wunused-but-set-variable]
wxappbar.cpp: In member function 'void WXAppBar::OnMove(wxMoveEvent&)':
wxappbar.cpp:469:10: warning: variable 'p' set but not used
[-Wunused-but-set-variable]
wxappbar.cpp: In member function 'void
WXAppBar::OnLeaveWindow(wxMouseEvent&)':
wxappbar.cpp:1020:94: error: 'class wxRect' has no member named 'Contains'
wxappbar.cpp: In member function 'void WXAppBar::OnTimer(wxTimerEvent&)':
wxappbar.cpp:1036:94: error: 'class wxRect' has no member named 'Contains'
make[3]: *** [wxappbar.lo] Error 1
make[3]: Leaving directory `/tmp/buildd/eviacam-1.5.2/wxutil'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/tmp/buildd/eviacam-1.5.2'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/tmp/buildd/eviacam-1.5.2'
make: *** [build-stamp] Error 2
signature.asc
Description: OpenPGP digital signature
