-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Peter,
some comments about your package. Note I'm no DD, so I can't sponsor you, therefore my suggestions may not be effectual for you. Note your package is not distributable in Debian as is (see below). * You built a native package, that's wrong (if you would have native package you would know :)). Learn more on [1] * You seem to use a merged changelog for your upstream changes and Debian related changes. Note this is not the intention of debian/changelog. The Debian changelog should highlight changes when compared to the upstream (source) distribution [2]. * You seem not to have filed an ITP for your package. Please do that if you want to introduce your application to Debian. This is to tell other people someone is working on a given package to avoid waste of resources. Learn more about ITPs on WNPP [3] * You Standards version is outdated, please bump to 3.9.2(.0) * Your binary dependencies are redundant (you have put openjdk-6-jre twice) and you depend on lame. Lame is not in Debian and since you have this as dependency, your package is not suitable at all to Debian. I'd suggest you to use another (available) alternative. Moreover I'm not entirely sure why you recommend Open-Office.org (maybe you could elaborate?). There is no OpenOffice in Debian anymore - please depend on Libre Office instead * Your synopsis line needs some improvements. Notably it should start with a lower case character [4]. Your long description reads fine, but I'm unsure why it would make sense to point out you/one can manage exactly 40k songs with it. * Your maintainer script miss the DEBHELPER hook, please leave that untouched from the template or add it again. Someone being familiar with desktop applications might also be able to tell, whether a postinst script is really supposed to call update-menu. afaict there is a hook for it (but I'm unsure) * You should rework your rules file. While it does not look terribly wrong you are really suggested to use debhelper scripts, for instance to install changelog (dh_installchangelogs), docs and so on. While doing you could also think about switching to dh 8 (debhelper(7)/dh(1)). This also includes to give the dpkg build tools a hint about your compatibility mode (debian/compat file). * You don't include a watch file [5]. This is not strictly required though. * Your debian/copyright file looks good, but it seems to be a scary mix between DEP-5 and traditional copyright files. It does not look entirely wrong, but there are some files without copyright statement. You should fix this for files you are authoritative (i.e. the author), e.g. tagbkup/build.sh. How are files like ptts/pgbennett_speech_Speaker.h generated? * What is tagbkup/? That looks like a bundled library. It is a policy violation to build a binary packages with bundled libraries. Moreover this is C code and therefore not platform independent (you specified architecture: any). Same may hold for other libraries/utilities you bundle (§ 4,13 [6]). * Your package is not Lintian clean: W: jampal: menu-item-creates-new-section Applications/Sound & Video /usr/share/menu/jampal:3 W: jampal: extra-license-file usr/share/jampal/COPYING W: jampal source: out-of-date-standards-version 3.8.4.0 [1] http://wiki.debian.org/DebianMentorsFaq#What_is_the_difference_between_a_native_Debian_package_and_a_non-native_package.3F [2] http://www.debian.org/doc/debian-policy/ch-source.html#s-dpkgchangelog [3] http://www.debian.org/devel/wnpp/ [4] http://www.debian.org/doc/debian-policy/ch-binary.html#s-descriptions [5] http://www.debian.org/doc/debian-policy/ch-source.html#s-debianwatch / uscan(1) [6] http://www.debian.org/doc/debian-policy/ch-source.html#s-embeddedfiles - -- with kind regards, Arno Töll GnuPG Key-ID: 0x9D80F36D -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJNzxgkAAoJEMcrUe6dgPNtS8AQAM8axE7xcSsyrkkl6U1WqRz6 4Hn4sTtvnbSSRwMc9FIL8MCVaCcBb8MS6eduT281hBU0SUp7nmBLQZTebukTJfV0 7wD/B1P6Nd0VhKWgApkz4iWNMPyPBreaCU8svTA7LqptQtOeVQBde7RcREJ2aoI6 5+IUBCVjMjzzuHJ/tlhX/V9DhMiqx3HeCrcZA7pvUXoLXfb/UxTwpvDxHsoo2lJY LNzpS+73atK2HSA5KsP7TscqwmNgPkSdV8JvX1z5CTlRzxjmfNa7tzdudv3XxWFk +HazCFZOTt8/MJrJk9RbOOumGRUe88GBynHrdGLYwieNOnU6njQyhtPJxMHuRDeZ MeYmcD3pkxhlIId0Ga8qAU06A5AvVEPrH3uyspMfrzWf0c6kW1YE0qRRlMiDzs/S mZMKuGAevFqWBGgmngX43AEQhm+ylSGJyUas1rgkVAxHrghqLQsslKwQYkEpBnCa H1xWyroU9RAgF0ef7DW6DBsOY1ZWqgzPUm1x6u2DP5Es24r4gaqqBWIdzlv3OEGM +xZIy0Zcz+N18eOzmSwQlP69b3L8hqF8+QdMFnU/CCtPp+1w+UukJRUtL27Udr5q OM42W4DJc1E7WBE6MI5y2zBzPnblFIdPIMWW9Vfj8OHHKrFOcbGEIqB8fOJZbVKe u26/gdnygBT/2A12VoV7 =OVUr -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4dcf1825.4020...@toell.net
