> On 01.05.2011 02:06, Håkon Nessjøen wrote: >> I would really like for a DD to look at my package, and be my sponsor, >> as I am eager to begin as an active package maintainer. This is >> hopefully the first of many to come. > > I am no DD, so feel free to ignore my advises but I really like the idea > of your package so I'd like to see it in Debian as well. Therfore I took > a quick look on it. > > Here are some hints:
Some other comments (non-DD review too): * In debian/rules, you probably want to get rid of the "sample" comments * In debian/rules, why exactly do you export DH_OPTIONS? * You might want to split the patches so it's easy to drop one of them individually when/if upstream accepts it (and you can then describe them better) * In debian-changes-0.3-1 you say "Upstream changes introduced in version 0.3-1", but it doesn't look to me that all those changes are indeed upstream, you might probably push them upstream before you can claim they are upstream :-) * Check the "Origin" field in DEP-3, you might want to push the changes upstream and then point to the relevant commits using that field Regards, -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/BANLkTi,ryyaqi+srkg4es+5tm+e87...@mail.gmail.com
