-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
hi Benoît, thanks for your review! i've packed a new upstream version of tomb and packaged it with some mentored corrections. it is now lintian clean and can be attained from http://apt.dyne.org/debian deb http://apt.dyne.org/debian stable main here below i'll reply to a few standing issues: On Tue, 08 Feb 2011, Benoît Knecht wrote: > Check your build dependencies, and also note that you shouldn't > explicitly depend on libraries: linking is automatically detected > and the necessary libraries are added to ${shlibs:Depends}. thanks, this was explained to me also by another mentor (antonio@dyne) > I would also change your Recommends to a Suggests [1]. > > [1] http://www.debian.org/doc/debian-policy/ch-relationships.html#s-binarydeps done. i'm also reviewing dependencies trying to put gksu (and several consequent gnome stuff) in Suggests > Another suggestion: since DEP-5 [2] is probably going to become > policy, it's recommended to use this format for the debian/copyright > file in new packages. > [2] http://dep.debian.net/deps/dep5/ i've read DEP-5 with interest. i find it a very good improvement to the present system! looking forward to use it in future. i guess is working with quilt 3.0 and git-buildpackage? that's what i'm happily using.. > Also, your debian/patches/debian-changes-0.9.1-1 patch is creating > several files, and making a bunch of other changes; since you're > upstream, it doesn't seem like it's intended. i believe you are talking about the diff that git-buildpackage generates against my "debian-orig0" branch? that is done automatically and i'm comfortably storing some modifications to the master branch which i do only for debian (like installation of menu files from configure rather than from "dirty" shellscripts) > Finally, "licensecheck -r tomb-0.9.1" reports some missing or > incomplete copyright headers; as upstream you can easily fix those. i've tried licensecheck myself, but it keeps reporting missing license in .c files where the license is actually included in the header comment. i suspect the error consists in the fact licensecheck doesn't tolerates change in spaces and justification of default license texts, since i'm frequently using the emacs justification on text in files. i guess licensecheck should be enhanced to be more fexible.. besides that, all files in distributed tomb upstream and debian package have a license notice. > In debian/dirs, you're instructing debhelper to create a usr/sbin > directory, but I guess you're not installing any file in it. that was it! fixed :) thanks, ciao - -- jaromil, dyne.org developer, http://jaromil.dyne.org GPG: B2D9 9376 BFB2 60B7 601F 5B62 F6D3 FBD9 C2B6 8E39 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQQcBAEBCAAGBQJNU/5qAAoJEAslGzkIl3JRpSMf/ieOwAW6KvVTC/rZI6IFE1wK G2HpYljC6vUIk/aGmd0NdxIJZXSqykJcY4LATTvKzbKVfL0pqEEM9fv3zRnrLjvn V6N9i8LNVJZGg6KsptJ3NtZaVCeyTQST2u8zQgbukZNjd3Ony1EL3gSUk0w+3QFw AcvJjC6931jzWRkxbZD6Uoic/5Dz7VYI8bEtEtTyvhrOguG14uncGbJV13a+eMlF fXxJ/Yz1I1f8A51gloIyW1/V3n9wQEhWvOb8bh+ZOP3L/r95y42DFQJGF0m+rNH8 DTvsjYJ2JdkUPqoCg+aLasGxdlQ3xaqV2X/ReyycUo8HuPtb2ZSWp7sqm4hbe5L1 azfuTw42xctg9G7hLWJBz0aTrzC/USn3UbAYEqWThPRr1QXqSEqQtzsCnxye39Wy xkkzKnFMcuouFQIA/Lf1PaLMeqgCLA6tYEXBA6Jal6H0FHJd1lpxmxOtY7Vs3X1K 8+GRKfBbzjzwQUB/ramAYhXNPzXYpaJbMpwLwctyML4PPwQ/AZ8kncGLG8sbbFsY 0i2fGSVq7kmrMem8fF0WAg1qOxeRfQ53gcn7ORZm/GmDGN7x+c4LKrEYhq44yi2T yQFzQquun5qKqrCQ2tKt42+NiuuATWMx78ntjjCWsY6OwOv3Iq1Dw+mXH0WZia7o V5i+swPPLSEHIAmWCaXSD7LSVTnNiGIwaa5T1Qfs8yC9zjYLY6nKVqmFrSw2dPo+ THaPOPFZx47WqxVz1grzwkVkhCcHpxWOZh7aeY+qRTnry7lDem2lRaJB8FaFG1Iz /tJ+Zi7k3ZSie2COkzc99aq8q0o1ghRA7WDOJpM2aKwvmo0eKN6vlAbxi9R+hwpX NEX4uIX9TJFFA/fqcQUTxvA9Y7tujiuqYVuLNp6dbgbrtm3wVU0QteHBCroEKcvw I49t9WaSjreBAgSUPqHkR0HzF3wKkTouVGORXPI8uAeq3XcfSG8wlAvtyWXQefyS oWc4T4D/VtF4/wGv1190pasVze57sFGefAa+mZfM1eVot3QabTgBvugepxjGBcYM 8d7D9PZ1bhimdQ6S+/UO+AIbSOeOSnJU3Fm+ajDB81Qh71/KomGBuyDDVrM+83wj l63Z6ff61ECaCF9fGFlTfj/WyteWNKbvA715BEM33qC5BMRVpJyMVlYzmha4HVt5 wyKoQ2bLHXruHyzRJWXWVy8JepIwml/R5qEix1++mfPBpjc7G+3bTAADkD3wT66o OP868mhxeovrtNNxML4gsGTqDAPEGDTiCLCyAlBKyYk0uAxXaQl/w1eIOCLI6A18 fqrZdmxHzPuLfeBUu4SD3Zl96OeT4CWhTWgNoevme0hAAhTF9G5MBnTb3ttP5uQ= =RaLP -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110210150415.ga27...@dyne.org
