On Thu, 21 Oct 2010 13:15:54 +0300, Bilal Akhtar wrote: > It builds these binary packages: > liboauth-dev - C library for implementing OAuth 1.0 (development files) > liboauth0 - C library for implementing OAuth > > - dget > http://mentors.debian.net/debian/pool/main/l/liboauth/liboauth_0.9.1-1.dsc
Quick review: * debian/watch: I wanted to suggest to use the sf redirector with something like http://sf.net/liboauth/liboauth-(.+)\.tar\.gz but apparently this doesn't work for not-yet uploaded packages. Maybe keep it in mind for the future. * debian/copyright: - The download URL is still wrong - The years of copyright are still wrong (and duplicated in the license), a quick grep through the code shows "2007-2010" as a superset of the different years. * debian/control: - I don't see a language-pack-en package in debian, and I still don't know why locales and locales-all are needed. I just built the package without "locales, locales-all | language-pack-en" in a sid cowbuilder chroot, and I saw that the tests are failing :) Some tests: "locales" alone is not enough, "locales-all" is enough. - cosmetic remark: I'd use the same (first paragraph of the) long description for both binary packages. * lintian detects the missing symbol control file, but I guess this can be added later too Cheers, gregor -- .''`. http://info.comodo.priv.at/ -- GPG key IDs: 0x8649AA06, 0x00F3CFE4 : :' : Debian GNU/Linux user, admin, & developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of Free Software Foundation Europe `- NP: Kings of Convenience: Summer On The West Hill
signature.asc
Description: Digital signature
