On Fri, Jul 23, 2010 at 8:45 PM, Eugene Paskevich <eug...@raptor.kiev.ua> wrote:
> I am looking for a sponsor for the new version 0.2.6-1 > of the package "libaosd". As promised on IRC, here is a review: Why did you add the libaosd-text-dev package? Policy 3.9.1 is out. You could mention in the changelog that the maintainer agreed to transfer maintainership of the package to you. Please run tagpending before uploading packages to mentors. Are you aware of the abi-compliance-checker package? It would be great if you could use it upstream to ensure you do not break the ABI. There is also this service based on that tool: http://linuxtesting.org/upstream-tracker/ As upstream, do you have any comments on #464744? Why did you drop this line from debian/rules? rm -f config.sub config.guess If you contact the openSUSE maintainer to ask them to update the package, you might want to get them to change the source package description, which is currently a copy of their libcaca source package description. aosd_cat also is obviously not written in C# :) The upstream build system hides the build commands, usually we prefer that they are shown so that looking at the build logs allows people to debug issues more easily. Some complaints from automated tools: lintian: I: libaosd source: binary-control-field-duplicates-source field "section" in package libaosd2 I: libaosd source: binary-control-field-duplicates-source field "section" in package libaosd-text2 I: aosd-cat: copyright-with-old-dh-make-debian-copyright P: aosd-cat: no-upstream-changelog I: aosd-cat: hyphen-used-as-minus-sign usr/share/man/man1/aosd_cat.1.gz:88 I: libaosd-dev: copyright-with-old-dh-make-debian-copyright P: libaosd-dev: no-upstream-changelog I: libaosd2: copyright-with-old-dh-make-debian-copyright P: libaosd2: no-upstream-changelog X: libaosd2: shlib-calls-exit usr/lib/libaosd.so.2.0.0 I: libaosd2: no-symbols-control-file usr/lib/libaosd.so.2.0.0 I: libaosd-text-dev: copyright-with-old-dh-make-debian-copyright P: libaosd-text-dev: no-upstream-changelog P: libaosd-text2: no-upstream-changelog I: libaosd-text2: copyright-with-old-dh-make-debian-copyright I: libaosd-text2: no-symbols-control-file usr/lib/libaosd-text.so.2.0.0 dpkg-shlibdeps: dpkg-shlibdeps: warning: dependency on libgmodule-2.0.so.0 could be avoided if "debian/aosd-cat/usr/bin/aosd_cat" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libcairo.so.2 could be avoided if "debian/aosd-cat/usr/bin/aosd_cat" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libgthread-2.0.so.0 could be avoided if "debian/aosd-cat/usr/bin/aosd_cat" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libpangocairo-1.0.so.0 could be avoided if "debian/aosd-cat/usr/bin/aosd_cat" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on librt.so.1 could be avoided if "debian/aosd-cat/usr/bin/aosd_cat" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libpthread.so.0 could be avoided if "debian/aosd-cat/usr/bin/aosd_cat" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libXfixes.so.3 could be avoided if "debian/libaosd2/usr/lib/libaosd.so.2.0.0" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libgmodule-2.0.so.0 could be avoided if "debian/libaosd-text2/usr/lib/libaosd-text.so.2.0.0" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libglib-2.0.so.0 could be avoided if "debian/libaosd-text2/usr/lib/libaosd-text.so.2.0.0" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libgthread-2.0.so.0 could be avoided if "debian/libaosd-text2/usr/lib/libaosd-text.so.2.0.0" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on librt.so.1 could be avoided if "debian/libaosd-text2/usr/lib/libaosd-text.so.2.0.0" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libpthread.so.0 could be avoided if "debian/libaosd-text2/usr/lib/libaosd-text.so.2.0.0" were not uselessly linked against it (they use none of its symbols). -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/aanlktinz=ytvguuzo2vy2yk-gixmc7chhs_4=bude...@mail.gmail.com
