Hi,
On Mon, May 24, 2010 at 09:27:29AM +0800, Paul Wise wrote:
> On Mon, May 24, 2010 at 2:21 AM, Marc Haber
> <mh+debian-ment...@zugschlus.de> wrote:
> > On Sun, May 23, 2010 at 11:12:40AM +0800, Paul Wise wrote:
> >> In dh_auto_install, does upstream's Makefile not support DESTDIR?
> >
> > Sadly, incorrectly.
> > make install DESTDIR=$(CURDIR)/debian/${PACKAGENAME}
> > places the executeable in
> > debian/nagios-plugin-check-multi/usr/lib/nagios-plugin-check-multi/check_multi,
> > ignoring the setting for libexecdir given on the configure command
> > line.
> > make install DESTDIR=$(CURDIR)/debian/${PACKAGENAME} \
> > LIBEXECDIR=/usr/lib/nagios/plugins
> > seems to do the trick, but I am not too sure whether this is really
> > better than the way I did things in the demo package.
>
> Sounds like a buggy configure.ac or Makefile.am.
I have already reported that upstream and have not yet recived a reply.
> > Is it common that DESTDIR= needs an absolute path ($(CURDIR)
> > prepended)? If I don't do this, the executeable is not even placed in
> > the package, but in plugins/debian/nagios-plugin-check-multi/...
>
> Not really sure to be honest.
I'll take a look at this in other packages and will probably report
this upstream as well.
> >> I also note that it uses /tmp/check_multi and wonder if that enables
> >> any symlink attacks.
> >
> > That is configurable. I could probably create
> > /var/cache/nagios-plugin-check-multi in postinst and use that as
> > tmpdir. Better idea?
>
> Definitely.
I have done this in the package now.
> Getting upstream/nagios3 to use a better default would be good too.
Will be reported once I have established contact with upstream.
I have uploaded a new package to
http://q.bofh.de/~mh/debian/nagios-plugin-check-multi/, and the git
repository can again be cloned from
http://q.bofh.de/~mh/debian/nagios-plugin-check-multi/git
I would like to solicit comments about the contents of the git
repository with regard to branches, upstream etc. I am not yet too
comfortable with git.
Greetings
Marc
--
-----------------------------------------------------------------------------
Marc Haber | "I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany | lose things." Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature | How to make an American Quilt | Fax: *49 3221 2323190
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20100524085354.gi23...@torres.zugschlus.de
