Hi Many thanks for reviewing my package.
I fixed most of things you told me. But I have a question about a warning you gave me on lintian : *script-with-language-extension usr/sbin/acgvision-agent.sh* I renamed the file to acgvision-agent. But now debuild tells it ignores the new file. I think i should include the change in the original source code (and the change is not debian specific) and so increment the version number from 5.1.4 to 5.1.5 Could anyone confirm me it is the right way to proceed or is there a cleaner way to proceed? Rémi Debay, ACGCenter Synergie Park Des Bonnettes 2, rue Willy Brandt 62000 Arras Ligne directe : +33 (0)3 21 15 36 36 Email : remi.de...@acgcenter.com www.acgcenter.com On Wed, Apr 21, 2010 at 9:46 PM, Torsten Werner <twer...@debian.org> wrote: > Hi Rémi, > > > > On Mon, Apr 19, 2010 at 4:24 PM, Rémi Debay <remi.de...@acgcenter.com> > wrote: > > I am looking for a sponsor for my package "acgvision-agent". > > there are some issues and some of them are not specific to Java: > > You should file a WNPP bug Cc-ing debian-j...@lists.debian.org and > close it through debian/changelog. > > The file debian/conffiles should not be needed. Please remove it. > > The binary package should not Depend: java-virtual-machine. Please remove > it. > > The binary package should not Depend on java2-runtime only. Please use > something like default-jre-headless | java2-runtime-headless - > whatever is correct for your package. Please ask if you are not sure. > > BTW, why do you Build-Depend: openjdk-6-jdk instead of default-jdk? Is > openjdk really needed for building? > > The long description has a typo (communcate), misses a full stop and > is very short. Please be more verbose. > > The copyright file is empty and wouldn't be accepted by the FTP team. > > Creating /var/log/acgvision in postinst shouldn't be needed but... > > ... postrm should remove /var/log/acgvision-agent only when purging. > But wait: is it /var/log/acgvision or /var/log/acgvision-agent? You > have the first variant in debian/dirs. > > prerm is virtually empty and should be removed. > > The #DEBHELPER# token is missing in all three scripts. > > You call ant directly without refering to $JAVA_HOME in debian/rules. > That is not good. Please check other packages that Build-Depend > java-helper for examples of better packaging practices. I have been > told that jsch might be such an example. And don't forget to read the > tutorial for java-helper. > > I cannot build the package because my cowbuilder does not work for > unknown reasons and that is why I stop checking your package now, > sorry. > > > Cheers, > Torsten >
