-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Julian Andres Klode schrieb:
> Am Dienstag, den 03.11.2009, 02:07 +0100 schrieb Gabriele Giacone:
>> Dear mentors,
>>
>> I am looking for a sponsor for my package "pidgin-skype".
>>
>> * Package name : pidgin-skype
>> Version : 0.1-1
>> Upstream Author : Eion Robb <eionr...@gmail.com>
>> * URL : http://eion.robbmob.com/
>> * License : GPLv3
>> Section : contrib/net
>>
>> It builds these binary packages:
>> pidgin-skype - Skype plugin for Pidgin
>>
>> This is the Skype API Plugin for Pidgin/libpurple/Adium. If you're
>> already running Skype, you can have your Skype contacts displayed with
>> your Pidgin/libpurple/Adium contacts. It is intended as a complete
>> replacement for the Skype user interface, hopefully everything you can
>> do in Skype you can do with this plugin.
>>
>> The package appears to be lintian clean.
>>
>> The package can be found on mentors.debian.net:
>> - URL: http://mentors.debian.net/debian/pool/contrib/p/pidgin-skype
>> - Source repository: deb-src http://mentors.debian.net/debian unstable
>> main contrib non-free
>> - dget
>> http://mentors.debian.net/debian/pool/contrib/p/pidgin-skype/pidgin-skype_0.1-1.dsc
>>
>> I would be glad if someone uploaded this package for me.
>
> Some random notes, without any intent to sponsor this package:
>
> * According to the website, the icons are non-free (CC-BY-NC-SA),
> and should thus be removed from the tarball. If they are now
> actually licensed under GPL, they still miss the source I
> guess (as there are only pngs).
Right, the icons are currently non-free, but pngs are also "free" and
licensable under the terms of the GPL, okay it does not make much sense,
but yeah..
Source of it? Open it and edit it :)
> * debian/README.* are templates and should be removed.
> * debian/copyright could use the DEP-5 format, i.e.
> dep.debian.net/deps/dep5/
> * You should probably not depend on pidgin, I guess the plugin
> is also useable from finch (the console version).
I agree with your points.
Also my bits of shit:
* debian/control:
- - no homepage field.
* debian/changelog:
- - you do not close an ITP bug
* debian/docs:
- - there are double ones
* debian/README.Debian:
- - install this file and please explain there, how to
install and use it
* debian/README.source:
- - remove it
* debian/rules:
- - remvoe the useless comments
Also you are missing build dependencys. Please build it in a clean
chroot, use e.g. pbuilder. I also expect, that there are some more
lintian errors/warnings, check it after building with -IE --pedantic
yourchanges.file:
dh_auto_build
make[1]: Entering directory `/tmp/buildd/pidgin-skype-0.1'
gcc -I/usr/include/libpurple -DPURPLE_PLUGINS -DENABLE_NLS -Wall
- -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
- -I/usr/include -I. -g -O2 -pipe libskype.c -o libskype.so -shared -fPIC
- -DPIC
In file included from skype_messaging.c:50,
from libskype.c:146:
skype_messaging_x11.c:23:22: error: X11/Xlib.h: No such file or
directory
skype_messaging_x11.c:24:23: error: X11/Xatom.h: No such file or
directory
In file included from skype_messaging.c:50,
from libskype.c:146:
skype_messaging_x11.c:26: error: expected '=', ',', ';', 'asm' or
'__attribute__' before '*' token
skype_messaging_x11.c:27: error: expected '=', ',', ';', 'asm' or
'__attribute__' before 'win'
skype_messaging_x11.c:28: error: expected '=', ',', ';', 'asm' or
'__attribute__' before 'skype_win'
skype_messaging_x11.c:30: error: expected '=', ',', ';', 'asm' or
'__attribute__' before 'message_start'
skype_messaging_x11.c:36: error: expected ')' before '*' token
skype_messaging_x11.c: In function 'skype_connect':
skype_messaging_x11.c:41: error: 'Window' undeclared (first use in this
function)
skype_messaging_x11.c:41: error: (Each undeclared identifier is reported
only once
skype_messaging_x11.c:41: error: for each function it appears in.)
skype_messaging_x11.c:41: error: expected ';' before 'root'
skype_messaging_x11.c:42: error: 'Atom' undeclared (first use in this
function)
skype_messaging_x11.c:42: error: expected ';' before 'skype_inst'
skype_messaging_x11.c:43: error: expected ';' before 'type_ret'
skype_messaging_x11.c:51: warning: implicit declaration of function
'XSetErrorHandler'
skype_messaging_x11.c:51: error: 'x11_error_handler' undeclared (first
use in this function)
skype_messaging_x11.c:53: error: 'disp' undeclared (first use in this
function)
skype_messaging_x11.c:53: warning: implicit declaration of function
'XOpenDisplay'
skype_messaging_x11.c:61: error: 'message_start' undeclared (first use
in this function)
skype_messaging_x11.c:61: warning: implicit declaration of function
'XInternAtom'
skype_messaging_x11.c:61: error: 'False' undeclared (first use in this
function)
skype_messaging_x11.c:62: error: 'message_continue' undeclared (first
use in this function)
skype_messaging_x11.c:63: error: 'root' undeclared (first use in this
function)
skype_messaging_x11.c:63: warning: implicit declaration of function
'DefaultRootWindow'
skype_messaging_x11.c:64: error: 'win' undeclared (first use in this
function)
skype_messaging_x11.c:64: warning: implicit declaration of function
'XCreateSimpleWindow'
skype_messaging_x11.c:65: warning: implicit declaration of function
'BlackPixel'
skype_messaging_x11.c:65: warning: implicit declaration of function
'DefaultScreen'
skype_messaging_x11.c:67: warning: implicit declaration of function
'XFlush'
skype_messaging_x11.c:73: error: 'skype_inst' undeclared (first use in
this function)
skype_messaging_x11.c:73: error: 'True' undeclared (first use in this
function)
skype_messaging_x11.c:74: error: 'None' undeclared (first use in this
function)
skype_messaging_x11.c:76: error: 'skype_win' undeclared (first use in
this function)
skype_messaging_x11.c:80: warning: implicit declaration of function
'XGetWindowProperty'
skype_messaging_x11.c:80: error: 'XA_WINDOW' undeclared (first use in
this function)
skype_messaging_x11.c:80: error: 'type_ret' undeclared (first use in
this function)
skype_messaging_x11.c:81: error: 'Success' undeclared (first use in this
function)
skype_messaging_x11.c:83: warning: implicit declaration of function
'XFree'
skype_messaging_x11.c: In function 'skype_disconnect':
skype_messaging_x11.c:101: error: 'XEvent' undeclared (first use in this
function)
skype_messaging_x11.c:101: error: 'e' undeclared (first use in this
function)
skype_messaging_x11.c:104: error: 'skype_win' undeclared (first use in
this function)
skype_messaging_x11.c:104: error: 'Window' undeclared (first use in this
function)
skype_messaging_x11.c:106: error: 'disp' undeclared (first use in this
function)
skype_messaging_x11.c:108: error: 'win' undeclared (first use in this
function)
skype_messaging_x11.c:110: error: expected expression before ')' token
skype_messaging_x11.c:111: error: 'DestroyNotify' undeclared (first use
in this function)
skype_messaging_x11.c:112: warning: implicit declaration of function
'XSendEvent'
skype_messaging_x11.c:112: error: 'False' undeclared (first use in this
function)
skype_messaging_x11.c:115: warning: implicit declaration of function
'XDestroyWindow'
skype_messaging_x11.c:117: warning: implicit declaration of function
'XCloseDisplay'
skype_messaging_x11.c: At top level:
skype_messaging_x11.c:125: error: expected ')' before '*' token
skype_messaging_x11.c: In function 'send_message':
skype_messaging_x11.c:137: error: 'XEvent' undeclared (first use in this
function)
skype_messaging_x11.c:137: error: expected ';' before 'e'
skype_messaging_x11.c:142: error: 'skype_win' undeclared (first use in
this function)
skype_messaging_x11.c:142: error: 'win' undeclared (first use in this
function)
skype_messaging_x11.c:142: error: 'disp' undeclared (first use in this
function)
skype_messaging_x11.c:155: error: 'e' undeclared (first use in this
function)
skype_messaging_x11.c:156: error: 'ClientMessage' undeclared (first use
in this function)
skype_messaging_x11.c:157: error: 'message_start' undeclared (first use
in this function)
skype_messaging_x11.c:167: error: 'False' undeclared (first use in this
function)
skype_messaging_x11.c:170: error: 'message_continue' undeclared (first
use in this function)
skype_messaging_x11.c:176: error: 'BadWindow' undeclared (first use in
this function)
skype_messaging_x11.c: In function 'receive_message_loop':
skype_messaging_x11.c:194: error: 'XEvent' undeclared (first use in this
function)
skype_messaging_x11.c:194: error: expected ';' before 'e'
skype_messaging_x11.c:200: error: 'x11_error_handler' undeclared (first
use in this function)
skype_messaging_x11.c:203: error: 'disp' undeclared (first use in this
function)
skype_messaging_x11.c:211: error: 'Bool' undeclared (first use in this
function)
skype_messaging_x11.c:211: error: expected ';' before 'event_bool'
skype_messaging_x11.c:213: error: 'event_bool' undeclared (first use in
this function)
skype_messaging_x11.c:213: warning: implicit declaration of function
'XCheckTypedEvent'
skype_messaging_x11.c:213: error: 'ClientMessage' undeclared (first use
in this function)
skype_messaging_x11.c:213: error: 'e' undeclared (first use in this
function)
skype_messaging_x11.c:230: error: 'message_start' undeclared (first use
in this function)
skype_messaging_x11.c:232: error: 'message_continue' undeclared (first
use in this function)
make[1]: *** [all] Error 1
make[1]: Leaving directory `/tmp/buildd/pidgin-skype-0.1'
dh_auto_build: make returned exit code 2
make: *** [build] Error 1
- --
/*
Mit freundlichem Gruß / With kind regards,
Patrick Matthäi
GNU/Linux Debian Developer
E-Mail: pmatth...@debian.org
patr...@linux-dev.org
Comment:
Always if we think we are right,
we were maybe wrong.
*/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAkrwazAACgkQ2XA5inpabMd/jwCfRsB/T612Etlc772c80jeR4st
VYsAmwfJOx8HulAzf5AHhUxR5tIfPLE+
=mVg+
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
