On Sun, Jul 05, 2009 at 01:13:30PM +0800, Paul Wise wrote: > Uploaded. I hope you both don't mind, but I took the liberty of > switching the urgency to medium instead of low due to the RC bug.
Thanks, that's fine. I nearly made it medium, but I couldn't find any written guidance on appropriate urgencies (is there some?) so I left it. I meant to ask. > Some things that may need looking at: > > In upstream's Makefile they use /usr as the default prefix. For stuff > installed from source they should be using /usr/local since /usr is > the domain of the package manager only. Please report this upstream. > > The upstream Makefile doesn't support the DESTDIR variable, the > install lines should look like this: > > install -v -m755 copher.pl $(DESTDIR)$(PREFIX)/bin/copher > install -v -m644 copher.1 $(DESTDIR)$(PREFIX)/share/man/man1/copher.1 I asked upstream about this when I first packaged it, but he had some good reason for leaving it as it was. > You might want to consider installing THANKS and README.rubyforge, > which were added in this version. I'll do that at the same time as expanding the description and improving debian/copyright next upload. > Shouldn't you depend on perl? I depend on libwww-mechanize-perl, which pulls in the current perl. Isn't that enough? (I'd like to hope libwww-mechanize-perl will always show this behaviour, after all.) > > Is it really appropriate to put the short git commit hashes in > debian/changelog? I don't think I'm alone in finding it helpful to identify a commit when cross-checking my other packages for consistency. It doesn't make the changelog any harder to read, AFAICS, but if there's some technical reason not to add them I'd like to know about it. > Upstream seems to have forgotten to announce 0.2.0 on freshmeat.net, > you might want to ping them or do the update yourself (since freshmeat > now allows editing by anyone). So he has. I wasn't aware Freshmeat was allowing general updates; I'll give him a prod first though. > You might want to suggest that upstream add a ideatorrent request for > sourceforge to add an API, that way the sf.net handling would be much > less brittle: > > http://sourceforge.net/apps/ideatorrent/sourceforge/ Good idea. Thanks for the pointers :) -- Jonathan Wiltshire 1024D: 0xDB800B52 / 4216 F01F DCA9 21AC F3D3 A903 CA6B EA3E DB80 0B52 4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51
signature.asc
Description: Digital signature
