Ben Finney wrote: > Howdy mentors, > > I am seeking a sponsor for my new package, ‘python-lockfile’ version > 0.7-2.
First of all, because you are not compiling anything, you don't have to build-depend on python-all-dev. In fact, you can simply build-depend on python [it's just copying the file to a directory]. And since you are using dh7, you can simplify your debian/rules even more. And using python-support instead of python-central would also reduce the complexity. And you should also install RELEASE-NOTES as changelog.gz, as specified in Policy 12.7: "If an upstream changelog is available, it should be accessible as /usr/share/doc/package/changelog.gz in plain text. [...] If the upstream changelog files do not already conform to this naming convention, then this may be achieved either by renaming the files, or by adding a symbolic link, at the maintainer's discretion." BTW, have you considered to use the original license for your packaging as well? Because the time you add a patch to your package, the combination of both is GPL licensed as well. Using the same license as the upstream helps people to detect the correct license of the resulting work in an easier manner (and upstream maybe likes you more if you use the same license). Last but not least, I prefer to sponsor packages using a single revision for every upload made to Debian. And before I forget to ask, why do you want this package to get into Debian? Summary and other small issues ------------------------------- debian/rules: - There is a char in line 23, which should not be there - The file could be much smaller by using dh's full power - RELEASE-NOTES should be installed as changelog debian/control: - Build-Depend on python instead of python-all-dev debian/copyright: - Update to the latest revision of the specification - Indent with one space, not with 4 spaces -- Julian Andres Klode - Free Software Developer Debian Developer - Contributing Member of SPI Ubuntu Member - Fellow of FSFE Website: http://jak-linux.org/ XMPP: juli...@jabber.org Debian: http://www.debian.org/ SPI: http://www.spi-inc.org/ Ubuntu: http://www.ubuntu.com/ FSFE: http://www.fsfe.org/
signature.asc
Description: Digital signature
