On Tue, Dec 16, 2008 at 12:47:44PM +0000, Andy Hawkins wrote: > * Package name : flactag > Version : 1.1-1 > Upstream Author : Andy Hawkins <a...@gently.org.uk> > * URL : http://software.gently.org.uk/flactag > * License : GPL > Section : sound
IANADD and can't upload for you, but some things to consider:
debian/changelog:
* you can't target stable, you probably want unstable or
perhaps experimental
* have you split the changelog entry into two lines for a reason? Don't
say bug#, just "Closes: #nnnnn" with your bug number
debian/control:
* if you are standards version 3.8.0, you need a Homepage field
* a full stop at the end of your description would be nice :-)
Your main binary doesn't have a man page.
debian/dirs:
* the only directory in here is created by the Makefile anyway, so get
rid of the file
debian/docs:
* you already turn flactag.1.txt into a man page and install it in your
Makefile, so you don't need this.
debian/flactag-doc.*:
* you don't have a binary package by this name, get rid of these too
debian/README.Debian:
* empty file, get it of it
You might consider using debhelper 7 and its beautiful rules automation.
Since your upstream build process is very straightforward, you rules
file might look like this:
#!/usr/bin/make -f
%:
dh $@
See [1] for more detail. Lose the comments and cruft while you're at it,
to make it easier to review.
debian/copyright:
* you need to acknowledge copyrights in base64.*
* most of your files are LGPL, with the exception of flactag.1.txt, is
there any reason for this? You need to mention the difference in
license.
* it's a lot easier if the packaging is licensed the same way as
upstream (LGPL, presumably, though your ITP claims GPL.)
You need a debian/watch file to comply with policy. It's used by uscan [2].
Good start, have a go at fixing these and then upload to mentors again. Some
sponsors prefer you to increment your version every review [3], some prefer
you to increment for an actual archive upload. For now I would
increment, you can always squash them down later if your sponsor prefers
it.
[1] http://manpages.ubuntu.com/manpages/intrepid/man1/dh.html
[2] man uscan
[3] dch -i
--
Jonathan Wiltshire
PGP/GPG: 0xDB800B52 / 4216 F01F DCA9 21AC F3D3 A903 CA6B EA3E DB80 0B52
Sending of encrypted mail is encouraged
signature.asc
Description: Digital signature
