Hi Russ and other mentors. On Sep 26 2008, Russ Allbery wrote: > Rogério Brito <[EMAIL PROTECTED]> writes: > > > I have uploaded it to mentors.debian.org. I hope that I have not > > introduced any bugs in the interim. Any comments about my changes are > > also very welcome. > > I'm happy to sponsor this upload since I use vsftpd. However, this change > is extraneous: > > * debian/patches/*: refreshed all patches.
Removed. Side comment: the current patches there are in a sad state of affairs. > and IMO actually made the diffs worse by introducing unnecessary leading > junk. This change would also probably rule out acceptance by > debian-release because it makes the diff too hard to review. > > * debian/control: Build-Depends on libcap2-dev. Closes: #492763 Removed. > is not a good change to make at this stage in the release cycle. lenny > will release with libcap1, so this can be fixed in the next release, and > it runs a relatively high risk of introducing new, subtle problems. Side comment: I have other improvements to the package, which seem fit to the next release. But filing bugs with patches ready for consumption and nothing are the same thing as far as I could understand from the BTS. :-( Maybe for a future iteration and an upload to experimental or something not targeted at lenny. > Also, these changes: > > * debian/patches/fix-nroff-warnings.patch: fix nroff warnings on manpages. > (lintian warning) > * debian/patches/manpage-debianization.patch: remove changes from .diff.gz. > (lintian warning) > > while reasonable are I think inappropriate at this stage of the release > cycle Removed. > and also make it harder to audit the debdiff, plus looking at the > diffs they're broken (you have the same block in both diffs). Side comment: If I were the maintainer of this package, I would merge those patches, but I tried not to be too invasive. I seemed that I was. :-) > Please re-upload without those changes and I'll be happy to upload this > NMU given that the maintainer is listed in LowNMU. The interdiff is now only a few lines. Potential sponsors should be very happy, since the changes are so small. For potential sponsors, the package is at mentors.debian.net, at: http://mentors.debian.net/debian/pool/main/v/vsftpd/vsftpd_2.0.6-1.2.dsc Regards, Rogério Brito. -- Rogério Brito : [EMAIL PROTECTED],ime.usp}.br : GPG key 1024D/7C2CAEB8 http://www.ime.usp.br/~rbrito : http://meusite.mackenzie.com.br/rbrito Projects: algorithms.berlios.de : lame.sf.net : vrms.alioth.debian.org -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
