-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Vincent et al.,
[uuwaf] > LGPL v4 does not exist ;-) But your debian/copyright is correct. You > might want to add the path to LGPL license on Debian systems (like you > did for GPLv2). Fixed. > About changelog, you should capitalize sentences and don't leave blank > lines between each point. Fixed. > In debian/control, I think that Vcs-Svn is waiting for an URL, not a > command. Just keep svn://... You may want to just depend on php5 which > already depends on what is needed. You might want to keep php5-cli only > if your package needs to launch php in cron.d (for example). It seems > this is not the case. Fixed. > You should also add a debian/watch file. Fixed. [opus] > Same remarks for changelog, control and copyright. I suppose that you > should keep php5-cli here because of cron.d entry. Fixed. > You embed tinymce. This is considered a bad thing. You should try to use > Debian tinymce and depends on it. If you need tinymce 3, that's fine, > this is the one currently in Debian. If you need tinymce 2, I am working > on it with tinymce maintainers. Fixed. > You should use ucf as you did for uuwaf to handle > debconf_config.php. This would allow the user to edit the file. Deleting > a file in /etc without advicing the user is considered bad practice > (even if you put a warning at the top of the file). Fixed, this one was fun! Thanks for your guidance on that. > I think that you should use invoke-rc.d to restart apache if needed: Fixed. > Note that configuring old Apache v1 may be considered unwelcome since > Debian is not shipping Apache v1 any more. You may want to read this for > the rationale: > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=434050 Removed support for installing apache1 config automatically. > Since you can break the webserver configuration by using Alias directive > in Apache configuration, you should leave it commented. If the user > wants to respect your alias, he will uncomment it. This was the tricky one we discussed, I still fear some of my userbase will find it hard to do this. So for now, I've opted for a note in the templates that warns about this and advises how to get round it. Is that reasonable? I plan to play with some sed to see if I can ask whether to enable it automatically or not. > You have a bogus postinst/postrm. It is better to remove them. Fixed. > You might want to contact debian-l10n-english to proofread description > and debconf questions. For debconf questions, this will be done later, > you will save translator time by asking now. Not done this yet, but I will, I've added two new templates, one to allow https, and the other to warn about aliases. > About cookie secret, I think that you should generate one randomly if > the user does not provide one. What happens if the field is left blank? Randomly produced one now in place. > About opus-doc, you ship generated latex files: > You should not even put source files into this package. Just put PDF > file. Now produced PDF file, still rather flawed, but it does have some value upon reflection. Thanks for all your advice, I hope I have taken it all on board and I feel it's really helped me improve the packaging more, and given me some more pointers for the future. If you'd be interested to see how I've done: opus is here http://mentors.debian.net/debian/pool/main/o/opus The respective dsc file can be found at: http://mentors.debian.net/debian/pool/main/o/opus/opus_4.0.2-2.dsc and uuwaf is here http://mentors.debian.net/debian/pool/main/u/uuwaf The respective dsc file can be found at: http://mentors.debian.net/debian/pool/main/u/uuwaf/uuwaf_1.0.1-3.dsc CT. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIMKjv0SwfPjLnaZYRAp2iAJ487kGfQICGxfWJPBMd1WNCjQmE3QCgwhrj /tUPwycjmE7bFLlaZWnBtF4= =3Gcm -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
