On Sun, Mar 23, 2008 at 05:05:11PM +1100, Jack Coulter wrote:
Hi Jack,
Some remarks,
I don't understand the goal of the binary-common and why you fork a make
command. I did this change on your makefile:
--- ../save/urbanterror-data-4.1/debian/rules 2008-03-15 05:14:37.000000000
+0100
+++ debian/rules 2008-03-23 14:10:40.000000000 +0100
@@ -26,7 +26,9 @@
### Data files
dh_install -i
-binary-common:
+
+# Build architecture independant packages using the common target.
+binary-indep: install-indep
dh_testdir -i
dh_testroot -i
dh_installchangelogs -i
@@ -38,11 +40,6 @@
dh_md5sums -i
dh_builddeb -i
-
-# Build architecture independant packages using the common target.
-binary-indep: install-indep
- $(MAKE) -f debian/rules DH_OPTIONS=-i binary-common
-
# Build architecture dependant packages using the common target.
binary-arch:
# Nothing to do
IMO, Pre-Depends can be avoid in you case, you should use Depends: here instead.
"Pre-Depends should be used sparingly, preferably only by packages whose
premature
upgrade or installation would hamper the ability of the system to continue
with
any upgrade that might be in progress."
http://www.debian.org/doc/debian-policy/ch-relationships.html
There is still some lintian warning:
W: urbanterror-data: no-debconf-config
W: urbanterror-data: malformed-title-in-templates urbanterror-data/license
W: urbanterror-data: too-long-extended-description-in-templates
urbanterror-data/license
W: urbanterror-data: postinst-uses-db-input
W: urbanterror-data: missing-debconf-dependency
W: urbanterror-data: latest-debian-changelog-entry-without-new-version
Cheers,
Gonéri
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
