Hi,
IANADD so I cannot sponsor your upload, but anyways some comments.
First of all:
You really should include the URL to the .dsc file of your package.
That way you make it a lot of easier for potential sponsors to find your
package and you higher the chances that a potential sponsor will have a
look at it.
General:
- inkblot links against libraries whose symbols it does not use.
Therefore dpkh-shlibdeps. Therefore you should try to fix that.
debian/control:
- Build-Depends for debhelper is over-precise. It should
be enough to depend on a version >= 5. Rationale: Specifying it more
precises has no benefit and makes life harder for backporters.
debian/copyright:
- Homepage in "... was downloaded from .. " differs from Homepage
field in debian/control. Why?
- You may want to consider adding machine-parseable informations to
this file, as this proposal [1] suggest.
- Personally I find the copyright file to be quiet cluttered. I'd do it
different. See for example dnsproxy or mantis from sid
for an example on how I would do it.
- See the lintian warning
debian/rules:
- There is no need to keep the dh-make comments :-)
- Its gould to have DEB_HOST_GNU_TYPE and such in your rules file to
make it behave better when beeing cross-built, but you should do it
different,
because this might be problematic when not beeing cross built. See [2]
- Personally I would prefer to make configure call multi-line (with
\ escaping the line break) for cosmetic reasons ;-)
- install target: You use make DESTDIR=foo install, dh_install and
additional delete files from the DESTDIR. Why? dh_install is not
really needed in here, you could do this with normal install
calls.
debian/manpages: What is this file for?
Best Regards
Patrick
[1] http://wiki.debian.org/Proposals/CopyrightFormat
[2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=423707
On Tue, Dec 11, 2007 at 12:13:08AM +0600, Sikon wrote:
> Original RFS: http://lists.debian.org/debian-mentors/2007/07/msg00735.html
>
> I have uploaded inkblot version 0.99.9-1. Also filed an ITP: Debian bug
> 455529, link: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=455529 .
>
> Sikon
--
in medias res Gesellschaft für Kommunikationstechnologien mbH
Dahlenerstr. 570
D-41239 Mönchengladbach
tel. +49 (0) 2166 - 9999 - 685
fax. +49 (0) 2616 - 9999 - 800
email: [EMAIL PROTECTED]
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
