Luca Bedogni wrote:
> On Tuesday 21 November 2006 15:38, Daniel Baumann wrote:
>> Luca Bedogni wrote:
>>> http://mentors.debian.net/debian/pool/main/l/libinstrudeo/
>> * you did modify Makefile.in and configure, this is not noted in the
>> changelog. was it done on purpose?
>
> Nope, i restored them
restored? what do you mean?
>> * why priority extra?
>
> Changed to optional. Is that correct?
yes.
>> * your copyright lacks the required information, look at libquicktime
>> from experimental to get a sane example.
>
> Yeah i've missed it, now i think it's ok..
yes.
>> * README does not contain usefull information, remove it from docs.
>
> Removed
additionally, i recommend you rename debian/docs to libstrudeo1.docs
mixing prefixed helper files and non-prefixed helper files in a
multi-binary package is error prone.
>> * /usr/lib/*.so belongs to the -dev package, not the lib package.
your install files are mixed up.
according to debian/control, you have a libstrudeo0 package.
in debian directory, there is libstrudeo1.install and
libstrudeo.install. please fix it.
>> * cleanup your rules, look at libquicktime from experimental for an
>> example.
>
> Mmm... What's wrong with the rules file?
remove this:
---snipp---
# -*- makefile -*-
# Sample debian/rules that uses debhelper.
# This file was originally written by Joey Hess and Craig Small.
# As a special exception, when this file is copied by dh-make into a
# dh-make output file, you may use that output file without restriction.
# This special exception was added by Craig Small in version 0.37 of
dh-make.
--snapp---
and remove this:
---snipp---
# shared library versions, option 1
version=2.0.5
major=2
# option 2, assuming the library is created as src/.libs/libfoo.so.2.0.5
or so
#version=`ls src/.libs/lib*.so.* | \
# awk '{if (match($$0,/[0-9]+\.[0-9]+\.[0-9]+$$/)) print
substr($$0,RSTART)}'`
#major=`ls src/.libs/lib*.so.* | \
# awk '{if (match($$0,/\.so\.[0-9]+$$/)) print substr($$0,RSTART+4)}'`
---snapp---
don't use double or more empty lines as seperator, one is just enough.
remove the useless, commented dh_* calls.
> Ok uploaded new version. Please recheck it if i've done all the things you
> said..
except from the mentioned things, the package is fine. please adjust
those, and i'll sponsor it.
--
Address: Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email: [EMAIL PROTECTED]
Internet: http://people.panthera-systems.net/~daniel-baumann/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
