James Westby wrote:
>
> I cannot sponsor I am afraid, but I have a few comments.
>
> * "Upgrade to debhelper v5, adjust the build-dependancy accordingly and
> bump debian/compat.", but debian/compat = 4.
Ouch! Fixed, thanks.
> * The description is a bit lacking in my opinion.
I'll discuss with the maintainer and will improve it in next uploads.
> * Please switch to ${binary:Version} in debian/control.
Done.
> * Is the rsskit.framework package needed? Is this a GNUStep
> convention?
It is a GNUstep convention (actually, a practice established by the
Debian GNUstep maintainers) and it's intended for convenience for
programmers who want to develop apps using the $framework.
> * Include the license header of the LGPL in debian/copyright.
Done.
> * The README.Debian should be README.Debian-source.
Done.
> * You can lose the configure target from debian/rules.
Done.
> > * The license notices in some of the files indicate that the license
> > is LGPL, which certainly is not the case. I suspect a copy/paste
> > error and asked upstream to correct this.
> >
> > * Oddly, the file RSSKit/GNUmakefile seems to be under LGPL. I have
> > indicated that in debian/copyright and asked upstream to clarify
> > this.
>
> Are these two points the same?
No, in the first case, the files clearly indicate that they're under
GPL, but contain the confusing "See the GNU Library General Public
License for more details". In the second point, this file is under
LGPL. I consider both cases as mistakes, since upstream added these
license headers before importing the source in Etoile's SVN and he was
in a hurry because of the forthcoming Etoile release. He didn't
answer my mail yet, but I hope he can resolve this in the next
release.
I have uploaded version -2 of the package with the changes you
suggested, thanks.
Margarita Manterola wrote:
>
> I wonder how it can be "your" package, when you are not the
> maintainer.
I used the template and didn't pay attention about this, sorry. Since
Gürkan Sengün invited me as co-maintainer, I feel it as "mine" in some
ways so I guess it's not a grave error.
> Anyway, I'm reviewing it and will probably upload it.
Thank you for your efforts.
