Tim Dijkstra wrote: > Hi, > > I need a sponsor for two packages: muswsusp and liblzf. The former > contains the binaries you need to use the new software suspend facility > available in the 2.6.17 kernel. I wrote some scripts to integrate with > mkinitramfs-tools.
I already talked with Tim privately about some issues which should be fixed / considered before the package is to be uploaded. A short summary: 1.) The package name. Upstream calls the package µswsusp, which stands for userspace software suspend. On mailing lists etc upstream uses the term uswsusp though. Googling for muswsusp yields 0 hits, searching for uswsusp ~900 hits directly related to the software. So the Debian package should be called uswsusp. Otherwise Debian users will have difficulties to find information on the net if they have problems. 2.) The initramfs-tools files are currently installed to /etc/mkinitramfs. The correct location though would be:´ /usr/share/initramfs-tools/hooks/resume and /usr/share/initramfs-tools/scripts/local-top/resume 3.) The postinst/postrm scripts check for the existence of /etc/mkinitramfs/initramfs.conf before update-initramfs is called. The new location (since v0.61 of initramfs-tools) is /etc/initramfs-tools/initramfs.conf 4.) README.Debian mentions the package mkinitramfs-tools, which should be initramfs-tools. It also says that update-initramfs has to be called with the parameter "-ur", which should be "-u". 5.) It installs a default configuration file /etc/suspend.conf where the value for "resume device" is unconfigured. Updating the ramdisk in postinst without a properly configured suspend.conf is useless because it leads to a non working setup. I'd suggest to create /etc/suspend.conf dynamically during postinst (This means it must not be installed as conffile). The value for "resume device" can be obtained by reading /proc/swaps which should be correct in 99% of all cases. Preserving user modifications could be handled by ucf. This way uswsusp would work out of the box giving the best user experience. 6.) Enable encryption support. This means linking against openssl so upstream should be asked for a special exemption [1] (or porting to gnutls) and installing the binary suspend-keygen. The RSA key could be generated during postinst using debconf for prompting for the encryption passphrase. This point is only a nice to have feature and imho not important for a first upload though. Otherwise the package looks fine and I'd really like to see it in the archive because it would be a valuable addition. Unfortunately I can't sponsor it myself. Cheers, Michael [1] http://www.gnome.org/~markmc/openssl-and-the-gpl.html -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
