Hi,
On Sat, May 27, 2006, Sam Morris wrote:
> The 'serpentine' source package is available from mentors.debian.net.
I had a preliminary look at your package, it's not uploadable as such
mostly because of lack of copyright information in debian/copyright,
and also because of the way arches without mono / muine are handled.
My full notes are below, please address or explain the points marked as
"required" and I'll finish the review.
debian/changelog:
- (required) dist will obviously have to be set to unstable
- I'd include the Ubuntu changelog, it carries history of the changes
Ubuntu did and might be useful to explain particular aspects of the
package
debian/control:
- please depends on ${misc:Depends} for all packages (might cause a
harmless warning)
- the muine plugin should probably Recommend muine
- (required) your muine build-dep should carry the same architectures
as your plugin package
debian/copyright:
- (required) I'm afraid you'll need to include the header of
serpentine/components.py as its copyright information herein
- (required) serpentine/converting.py, serpentine/gaw.py,
serpentine/gdkpiechart.py, serpentine/gtkutil.py,
serpentine/mastering.py, serpentine/operations.py,
serpentine/urlutil.py, serpentine/xspf.py, and most things below
serpentine/plugins/ are LGPL, please mention that
- you might want to contact upstream to change the copyrights
mentionned above to have simpler copyright terms in serpentine, e.g.
to move everything to GPL or to LGPL
debian/rules:
- (required) you're passing --enable-muine on all arches, yet the
configure script will give up if you pass --enable-muine on arches
which can't install mono
- I suggest using DEB_CONFIGURE_EXTRA_FLAGS += instead of :=
The README says the software needs libnautilus-burn-python, how do you
do without?
You should contact upstream to update to the new FSF address and to add
copyright information to Python sources which don't have any (e.g.
scripts/serpentine).
Bye,
--
Loïc Minier <[EMAIL PROTECTED]>
"You can gtk_main_run, but you can't gtk_widget_hide." --danw, 19-jul-04
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
