On Mon, Apr 28, 2003 at 08:11:22PM +0200, Tobias Toedter wrote:
> qbrew uses a configure script and compiles nearly out of the box -- so as an
> experienced developer, you shouldn't have any difficulties in packaging
^^^^^^^
> yourself and checking my package. Probably only a matter of minutes... ;-)
^^^^^^^
Eh? apt-get install joshk? ;)
I can't sponsor anyone (not a DD yet), but the package looks good to
me... Here's some nit picking though.
ifeq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
INSTALL_PROGRAM += -s
endif
You use dh_strip - this is taken care of already.
# dh_installdebconf
# dh_installlogrotate
# dh_installemacsen
^ you might as well just take these out... no one cares about those :)
along with the other stuff you don't use ;)
You also specify a CFLAGS, but when you start the make you have to pass
your local CFLAGS variable to the make command. I.e. $(MAKE)
CFLAGS="$(CFLAGS)" would work. This depends on the nature of the
makefile, it might also accept CFLAGS as an environment variable in
conjunction with its own so you don't have to reproduce their special
CFLAGS when adding your own. Check and see...
But otherwise, it's pretty good... :)
Regards
Josh
--
New PGP public key: 0x27AFC3EE
pgpd2haMVJucd.pgp
Description: PGP signature
