Hi Tobi, Thank you so much for your detailed review and for catching these issues! I really appreciate your guidance on Debian packaging best practices. I have addressed all your points with careful fixes, and the details are as follows:
### 1. Fixes for debian/changelog - **Preserved all historical entries**: I kept all original NMU and archive entries intact to avoid "rewriting history" (my initial mistake was repeating NMU entries, which I have now removed). - **Clarified the #1113091 fix**: I revised the changelog entry to clearly state: > "Upstream has natively fixed FTBFS with CMake 4, remove the temporary NMU patch for #1113091" This properly explains that we are using the upstream's native fix instead of the temporary NMU patch, without incorrectly re-closing the bug. - **Corrected Standards-Version**: Fixed the typo from 4.7.0 to 4.7.3. - **Documented +ds repack with specific details**: Added a clear, policy-aligned explanation for the +ds suffix: > "Add +ds suffix to repack upstream source: > - Exclude bundled boost library in Utilities/boost and Utilities/updateBoost.sh, use system libboost-dev instead > - Follow Debian Policy §4.13 (No bundled libraries)" This explains exactly what was excluded and why, following Debian's best practices for bundled libraries. - **No modification of old entries**: I did not alter any historical changelog entries, only added my new ITA entry at the top. ### 2. Fix for debian/copyright - **Documented the removal of obsolete copyright paragraphs**: The deleted paragraphs corresponded to files that no longer exist in the latest upstream git version. I added a clear changelog entry explaining this: > "Remove obsolete copyright paragraphs from debian/copyright: > - The corresponding files (Utilities/KWSys/hash_fun.hxx.in, > Utilities/KWSys/hash_map.hxx.in, Utilities/KWSys/hash_set.hxx.in, > Utilities/KWSys/hashtable.hxx.in) no longer exist in the latest > upstream git version" This is a clean-up of outdated copyright information for files that are no longer present in the source tree. ### 3. Re-upload to mentors I have rebuilt the source package with all the above fixes and re-uploaded it to mentors (version number remains unchanged: 1.1.0~git20250114.eb1e46d+ds-1). The updated package is available here: https://mentors.debian.net/package/kwstyle/ I apologize for the initial non-standard issues—this is my first ITA package, and I have learned a lot about Debian Policy from your review. I will strictly follow these best practices for all future maintenance. Please let me know if there are any further adjustments needed. Thank you again for your time and help! Best regards, Ching He (何庆) [email protected] GPG key ID: 0ACF9AD8D2A9937D
signature.asc
Description: PGP signature
