Control: tags -1 moreinfo On Thu, 20 Mar 2025 17:37:54 +0100 "Alexandre Rossi" <n...@zincube.net> wrote:
> I am looking for a sponsor for my package python-whisper:
hi Alexandre,
thanks for picking up the slack on this long neglected package. Some
issues and suggestions:
* changelog: when doing a team upload (such as this) it is customary
to add an explicit entry mentioning just that (e.g. 'dch --team'),
to clearly distinguish the upload from an NMU.
* copyright: could use standard license short-name cf. [1], i.e.
"Apache-2.0".
* control:
+ build-depend on python3 is redundant (implied by python3-all).
+ current standards-version is 4.7.2.
+ 'Conflicts: python-whisper' looks obsolete; that python2 package
was last seen in stretch.
+ please add an autopkgtest, even the trivial 'Testsuite:
autopkgtest-pkg-python' is better than nothing.
+ missing hard dependencies for unconditional imports in the scripts
installed into /usr/bin:
- bin/rrd2whisper.py:11: import rrdtool
- contrib/whisper-auto-resize.py:84: from carbon.conf import settings
- contrib/whisper-auto-resize.py:94:from carbon.storage import
loadStorageSchemas, loadAggregationSchemas
* lintian hits about library-package-name-for-application and
application-in-library-section might qualify for overrides in
packages that are primarily a python module but also ship small or
trivial scripts on the side.
Any reason for not putting the upstream testsuite to good use, on
build and/or in an autopkgtest context?
Please enable the CI on salsa [2], it's a great quality control tool
and time saver.
[1]https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-short-name
[2]https://salsa.debian.org/salsa-ci-team/pipeline#activate-salsa-ci
Please remove the moreinfo tag (and CC me) once you have an updated
package ready.
pgpMHyjQImM9U.pgp
Description: OpenPGP digital signature
