Control: tags -1 moreinfo On Fri, 7 Mar 2025 20:37:31 +0100 (CET) ch...@chancellor.cc wrote:
> I am looking for a sponsor for my package python-certbot-dns-luadns:
hi Chris,
the package is in decent shape overall, but does need a few fixes
before I can upload:
* watch: the signature file appears unavailable via pypi.debian.net.
While checking the signature is a good idea, with verification
broken by the missing asc file 'uscan' errors out when trying to
download upstream releases: "failed: 404 NOT FOUND uscan die: FAIL
Checking OpenPGP signature (no signature file downloaded)".
You might want to point the watch file to whatever repository you
actually downloaded the tarball and signature from (github?).
* control:
+ the ancient version requirement for the build-dependency on
python3-sphinx is already met in oldstable, please remove.
+ the package should build-depend on python3-all rather than
python3, so that the testsuite can be run on build with all
supported Python versions.
+ the letsencrypt team is set as maintainer but the package isn't
actually in the team repo. This would cause the team to receive
bug reports and such for a package not under their control.
Probably best to switch the maintainer and uploader roles around
for now, even if you plan on eventually making this a team pkg.
+ binary package python3-certbot-dns-luadns would benefit from a
suggested dependency on the -doc package.
+ the versioning of the *-abi-2 build-dependencies seems to have
been overlooked when moving from 2.9.0 to 2.11.0?
* rules: you could use execute_after_dh_auto_build in place of the
override.
The build tries to pull in intersphinx inventory from the internet.
Instead of blocking that and letting sphinx continue without these
resources, the intersphinx_mapping in docs/conf.py could be patched
to point to local files (see [2] for numerous examples):
'https://acme-python.readthedocs.org/en/latest/objects.inv' ->
/usr/share/doc/python-acme-doc/html/objects.inv (in python-acme-doc)
'https://docs.python.org/objects.inv' ->
/usr/share/doc/python3/html/objects.inv (via python3-doc)
'https://eff-certbot.readthedocs.io/en/stable/objects.inv' ->
/usr/share/doc/python3-certbot/html/objects.inv (in python-certbot-doc)
Obviously, this approach would also require adding the relevant
documentation packages as build-dependencies.
Consider enabling the CI on the salsa repo [1], it's a great time
saver and quality control tool.
[1]https://salsa.debian.org/salsa-ci-team/pipeline#activate-salsa-ci
[2]https://codesearch.debian.net/search?q=objects.inv+path%3Adebian%2Fpatches&literal=1
Please remove the moreinfo tag (and CC me) once you have an updated
package ready.
pgpP3WKwDX6qe.pgp
Description: OpenPGP digital signature
