Control: tags -1 moreinfo On Tue, 25 Feb 2025 21:26:16 +0100 Carl Keinath <carl.kein...@gmail.com> wrote:
> I am looking for a sponsor for my package glaze:
hi Carl,
I reviewed the package, and some issues came up:
* watch: unnecessary searchmode=html option?
* copyright: missing multiple copyright holders and years, as well as
at least one file under an entirely different license:
- cmake/code-coverage.cmake:2
- include/glaze/util/itoa.hpp:31
- include/glaze/util/expected.hpp:4
- include/glaze/util/fast_float.hpp:30
- include/glaze/util/fast_float.hpp:58
- include/glaze/util/dragonbox.hpp:1
- include/glaze/api/xxh64.hpp:4
* control:
+ why 'architecture: any' (rather than 'all') for a header-only
package, with zero architecture-dependent content?
+ the upstream README explicitly states (under "Compiler/System
Support") that glaze only support little-endian systems; a
limitation like that probably belongs in the description.
+ why 'Multi-Arch: same'?
* rules: please remove clutter that is irrelevant for this package,
such as examples for setting compiler flags and hardening.
* tests: consider putting the upstream testsuite to good use (even if
you don't want to run it on build), for example in an autopkgtest
context. This is not required by policy, but often does provide
useful early warning for issues introduced by changes elsewhere.
Please enable the CI on the salsa repo [1], it's a great quality
control tool for yourself and sponsors alike.
Please remove the moreinfo tag (and CC me) once you have an updated
package ready.
[1]https://salsa.debian.org/salsa-ci-team/pipeline#activate-salsa-ci
pgplqyhqLiiCB.pgp
Description: OpenPGP digital signature
