On Sun, Feb 09, 2025 at 01:12:32PM +0000, Jing Luo wrote: > Package: sponsorship-requests > Severity: normal > X-Debbugs-Cc: nabijaczlew...@nabijaczleweli.xyz > > * Package name : cvsweb > Version : 3:3.0.6-9 > Upstream contact : https://cvsweb.bsd.lv/ > * URL : https://cvsweb.bsd.lv/ > * License : BSD-2-clause > * Vcs : https://salsa.debian.org/debian/cvsweb > Section : vcs > > dget -x > https://mentors.debian.net/debian/pool/main/c/cvsweb/cvsweb_3.0.6-9.dsc > > Changes since the last upload: > > cvsweb (3:3.0.6-9) unstable; urgency=medium > . > [ наб ] > * Vcs-Git: https://salsa.debian.org/debian/cvsweb.git > . > [ Jing Luo ] > * d/control: upgrade standards version to 4.7.0 > * d/control: upgrade debhelper-compat to 13 > * d/control: change the homepage url to cvsweb.bsd.lv > * New maintainer (Closes: #660684, #1054260) > * d/watch: fix the url to upstream > * d/copyright: rewrite in DEP 5 format > * d/gbp.conf: add a gbp.conf > * d/patches: add more DEP 3 headers > * add a patch to fix a non-unicode char in cvsweb.conf > * New maintainer (Closes: #660684, #1054260) > * d/watch: fix the url to upstream > * d/copyright: rewrite in DEP 5 format > * d/gbp.conf: add a gbp.conf > * d/patches: add more DEP 3 headers > * add a patch to fix a non-unicode char in cvsweb.conf > * d/rules: remove --parallel because it's the default since debhelper 10 > * add a lintian-overrides file for source
Overall looks pretty good, but note:
* You have doubled changelog entries.
* Accd'g to its description,
cvsweb-3.0.6+9/debian/patches/0003-483442-fix-perl-510-test-failure.patch
can be dropped.
* I disagree with your assessment of Forwarded: not-needed for most patches
(for example, Perl 5.18 is definitely forwardable!).
* lintian-overriding pedantic and especially pedantic+experimental tags
makes very little sense (and "I can't decide what to write" is a bad override
reason).
* As for maintainer-manual-page's "don't know how to contact upstream" comment:
* I see Homepage: https://cvsweb.bsd.lv/ ->
CVSweb was originally developed by members of the FreeBSD project and is
currently maintained by on BSD.lv.
Copyright © 2019 Ingo Schwarze, $Date: 2020/10/05 10:40:32 $
release notes -> by schwarze
so it'll be Ingo Schwarze <schwa...@openbsd.org>.
Whether you want to actually post the patches and/or manual to him is up to you,
but you should definitely get him to fix the webpage.
Best,
signature.asc
Description: PGP signature
