Le sam. 8 févr. 2025 à 11:47, Laurent Arnoud <laur...@spkdev.net> a écrit :
> Hi Jérémy, Phil, > > > > Le sam. 16 nov. 2024 à 18:34, Jérémy Lal <kapo...@melix.org> a écrit : > > > > I'm reviewing your package ! > > Thanks! > > > > 1. it would be great to team-maintain this into nginx or lua team. > > > Please consider it ! (you'll need to request salsa access to the team > > > that fits you the best, move your repo there, and update d/control to > > > reflect those changes). > > I did not found any group for the lua-nginx-* packages so I've requested > access > to the nginx-team in salsa, I hope its ok and will reflect the changes on > the > d/control if its accepted. > There is no "lua nginx" team. Considering this package is mostly lua, it makes sense to go the lua team. > > > 2. Do not depend on nginx-extras. Nginx now builds all its modules in > > > separate packages. > > I see its done. > > > > 3. Depend on libnginx-mod-http-lua. > > Ok done. > > > > 3. d/control long description contains a huge part that describes what > is > > > libnginx-mod-http-lua, not this package. That's overkill. > > > Also it mentions nginx-extras too, which should be removed. Ideally, autopkgtests should be enabled, so we can actually make sure we didn't miss something... Yes I must have copy/paste that a while ago. > > > > 4. the d/watch file could be updated, see uscan(1) #github > > I've tried to update it, look to work wdyt? > Seems to be good. Did you forget to push tags to the salsa repository ? I can't gbp export-orig. Thanks
