Control: tags -1 +confirmed

Xiyue,

Preamble...

Thank you for taking the time to prepare this package and your contribution to
the Debian project.

This review is offered to help package contributors to Debian mentors improve
their packages (where needed) prior to possible sponsorship into Debian by a
Debian Developer.


Review...

1. Build:

  * pbuilder [1]: Good
 
  * sbuild [2]: Good


2. Lintian [3]: Good


3. Licenses [4]: Good


4. Watch file [uscan --force-download]: Good


5. Build Twice (build source after successful build) [1]: Good


6. Reproducible builds [5]: Good

Note: Test does not block sponsorship and is for information only at this time.


7. Tail of the ratt (architecture dependant packages only) [6]: Good

Note: Test does not block sponsorship and is for information only at this time.


8. Install [No previous installs]: Good


9. Upgrade [Over previous installs if any]: N/A


Additional...

Nothing.


Summary...

I believe 'emacs-llama' is ready for review/possible sponsorship.

If you do not have upload rights or a regular sponsor. You can follow the RFS
process linked to below.

https://mentors.debian.net/sponsors/rfs-howto/


Please try the below on your packages...

[1] pbuilder:

  * Command for 1.: sudo pbuilder build <PACKAGE>.dsc
  * Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks


[2] sbuild:

  * Command: sbuild -d unstable <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild
  * autopkgtests. See link below.

    https://wiki.debian.org/sbuild#Using_qemu_for_autopkgtests


[3] lintian:

  * Command: lintian --display-info --verbose --fail-on error --info --pedantic
--show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different
results, so be thorough.
  * Document: https://wiki.debian.org/Lintian


[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

  Note: Please report false positives as bug reports against 'licenserecon'

Reply via email to