Control: tags -1 +confirmed

Danial,

Preamble...

Thank you for taking the time to prepare this package and your contribution to
the Debian project.

This review is offered to help package contributors to Debian mentors improve
their packages (where needed) prior to possible sponsorship into Debian by a
Debian Developer.


Review...

1. Build:

  * pbuilder [1]: Good
 
  * sbuild [2]: Good


2. Lintian [3]: Good


3. Licenses [4]: Good


4. Watch file [uscan --force-download]: Information only

philwyett@ks-tarkin:~/Development/builder/debian/showtime-47.0$ uscan --force-
download 
uscan warn: Possible OpenPGP signature found at:
  
https://gitlab.gnome.org/GNOME/Incubator/showtime/-/archive/47.0/showtime-47.0.tar.bz2.asc
 * Add opts=pgpsigurlmangle=s/$/.asc/ or opts=pgpmode=auto to debian/watch
 * Add debian/upstream/signing-key.asc.
 See uscan(1) for more details
Successfully renamed ../showtime-47.0.tar.bz2 to ../showtime_47.0.orig.tar.bz2.


5. Build Twice (build source after successful build) [1]: Good


6. Reproducible builds [5]: Good

Note: Test does not block sponsorship and is for information only at this time.


7. Tail of the ratt (architecture dependant packages only) [6]: N/A

Note: Test does not block sponsorship and is for information only at this time.


8. Install [No previous installs]: Good


9. Upgrade [Over previous installs if any]: N/A


Additional...

A. Anomaly to maybe investigate.

   dh_installdocs
   dh_installchangelogs
   dh_installman
   dh_python3
E: dh_python3 dh_python3:198: no package to act on (python3-foo or one with
${python3:Depends} in Depends)
   dh_installgsettings
   dh_icons
   dh_perl
   dh_link


Summary...

I believe 'showtime' is ready for review/possible sponsorship. Could a Debian
Developer (DD) with available free time, please review this package and upload
if you feel it is ready and appropriate for the distribution.


Please try the below on your packages...

[1] pbuilder:

  * Command for 1.: sudo pbuilder build <PACKAGE>.dsc
  * Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks


[2] sbuild:

  * Command: sbuild -d unstable <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild
  * autopkgtests. See link below.

    https://wiki.debian.org/sbuild#Using_qemu_for_autopkgtests


[3] lintian:

  * Command: lintian --display-info --verbose --fail-on error --info --pedantic
--show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different
results, so be thorough.
  * Document: https://wiki.debian.org/Lintian


[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

  Note: Please report false positives as bug reports against 'licenserecon'

Reply via email to