Hi Jeroen,
thanks for the comprehensive analysis of findent.
I think I was able to implement all of your comments,
if not, let me know, no problem at all.
I uploaded a new version of findent: findent-4.3.5 :
https://mentors.debian.net/package/findent/
https://mentors.debian.net/debian/pool/main/f/findent/findent_4.3.5-1.dsc
and I will remove the moreinfo tag, cc-ing you.
Regards,
Willem
On 1/30/25 12:32, Jeroen Ploemen wrote:
Control: tags -1 moreinfo
On Thu, 9 Jan 2025 16:02:34 +0100
Willem Vermin <wver...@gmail.com> wrote:
I am looking for a sponsor for my package findent:
hi Willem,
as noted by Phil, the package seems to build and pass the usual test
just fine. Some other stuff came up during review though:
* changelog: there are changes in d/copyright without mention in
the Debian changelog. Please document all packaging changes.
* copyright: version mix-up in the new paragraph for the builtparser
files: "On Debian systems, the full text of the GNU General Public
License version 2 can be found in the file [...]/GPL-3".
* copyright: the paragraph for vim/findent.vim and vim/fortran.vim
defines the license for these files as 'Fair'. Details of that
license don't seem to be present anywhere in the upstream sources,
but exist only in d/copyright:
> Usage of the works is permitted provided that this instrument is
> retained with the works, so that any entity that uses the works
> is notified of this instrument.
> DISCLAIMER: THE WORKS ARE WITHOUT WARRANTY.
I realise you are both upstream developer and Debian maintainer for
this package, but those are two separate roles. If you wish to
license files in a certain way, you want to wear your upstream hat
and ensure the terms are part of the upstream source release.
The license text, as quoted above, only grants permission for
'usage', but not modification or distribution, and requires users
are to be 'notified of this instrument' whatever that is supposed
to entail. Those terms likely fall short of the requirements set in
the DFSG [1].
Is there any benefit or purpose to having these specific files under
a custom license versus the standard 3-clause BSD that applies to
most of the source code?
[1]https://wiki.debian.org/DebianFreeSoftwareGuidelines
Please remove the moreinfo tag (and CC me) once you have an updated
package ready.
