Control: tags -1 +confirmed Matthew,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. This review is offered to help package contributors to Debian mentors improve their packages (where needed) prior to possible sponsorship into Debian by a Debian Developer. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Information only Running lintian... N: I: rumur: file-references-package-build-path [usr/include/rumur/location.hh] N: N: The listed file or maintainer script appears to reference the build path N: used to build the package as specified in the Build-Path field of the N: .buildinfo file. N: N: This is likely to cause the package to be unreproducible, but it may also N: indicate that the package will not work correctly outside of the N: maintainer's own system. N: N: Please note that this tag will not appear unless the .buildinfo file N: contains a Build-Path field. That field is optional. You may have to set N: DEB_BUILD_OPTIONS=buildinfo=+path or use N: --buildinfo-option=--always-include-path with dpkg-buildpackage when N: building. N: N: Please refer to https://reproducible-builds.org/, N: https://wiki.debian.org/ReproducibleBuilds/BuildinfoFiles, and the N: dpkg-genbuildinfo(1) manual page for details. N: N: Visibility: info N: Show-Always: no N: Check: files/contents N: N: I: rumur: file-references-package-build-path [usr/include/rumur/parser.yy.hh] N: N: The file share/README.rst is installed to usr/share/rumur/lib/README.rst, N: triggering Lintian warnings about documentation installed outside N: /usr/share/doc. This file qualifies for an exemption because it describes N: the purpose of the directory it is installed into. O: rumur: package-contains-documentation-outside-usr-share-doc [usr/share/rumur/lib/README.rst] N: N: This package ships a documentation file outside /usr/share/doc N: Documentation files are normally installed inside /usr/share/doc. N: N: If this file doesn't describe the contents or purpose of the directory it N: is in, please consider moving this file to /usr/share/doc/ or maybe even N: removing it. If this file does describe the contents or purpose of the N: directory it is in, please add a lintian override. N: N: Visibility: info N: Show-Always: no N: Check: documentation N: N: Screen: python/egg/metadata N: Advocates: "Scott Kitterman" <deb...@kitterman.com> N: Reason: The folders XXX.dist-info/ and XXX.egg-info/ hold metadata for N: Python modules. Those files are not documentation even though N: some of their names carry the .txt file extension. N: N: Python modules can be both public and private. N: N: Read more in N: https://www.python.org/dev/peps/pep-0427/#the-dist-info-directory, N: https://www.python.org/dev/peps/pep-0376/#id16, N: https://www.python.org/dev/peps/pep-0610/, N: https://www.python.org/dev/peps/pep-0639/, N: https://setuptools.pypa.io/en/latest/deprecated/python_eggs.html, N: and Bug#1003913. N: I: Lintian run was successful. 3. Licenses [4]: Good 4. Watch file [uscan --force-download]: Good 5. Build Twice (build source after successful build) [1]: Good 6. Reproducible builds [5]: Good Note: This test does not block sponsorship and is for information only at this time. 7. Tail of the ratt (architecture dependant packages only) [6]: Good Note: This test does not block sponsorship and is for information only at this time. 8. Install [No previous installs]: Good 9. Upgrade [Over previous installs if any]: Good Summary... I believe 'rumur' is ready for review/possible sponsorship. Could a Debian Developer (DD) with available free time, please review this package and upload if you feel it is ready. Please try the below on your packages... [1] pbuilder: * Command for 1.: sudo pbuilder build <PACKAGE>.dsc * Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild -d unstable <PACKAGE>.dsc * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian --display-info --verbose --fail-on error --info --pedantic --show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon Note: Please report false positives as bug reports against 'licenserecon'
