Control: tags -1 +confirmed

Thomas,

Preamble...

Thank you for taking the time to prepare this package and your contribution to
the Debian project.

This review is offered to help package contributors to Debian mentors improve
their packages (where needed) prior to possible sponsorship into Debian by a
Debian Developer.


Review...

1. Build:

  * pbuilder [1]: Good
 
  * sbuild [2]: Good


2. Lintian [3]: Good


3. Licenses [4]: Good


4. Watch file [uscan --force-download]: Good


5. Build Twice (build source after successful build) [1]: Good


6. Reproducible builds [5]: Good

Note: This test does not block sponsorship and is for information only at this
time. It is good if a package passes this test.


7. Tail of the ratt (architecture dependant packages only) [6]: Good

Note: This test does not block sponsorship and is for information only at this
time. It is good if a package passes this test.

philwyett@ks-tarkin:~/Development/builder/debian$ ratt --dist trixie
tsctp_0.8.1-1_amd64.changes 
2025/01/30 17:43:23 Loading changes file "tsctp_0.8.1-1_amd64.changes"
2025/01/30 17:43:23  - 2 binary packages: tsctp tsctp-dbgsym
2025/01/30 17:43:23 Corresponding .debs (will be injected when building):
2025/01/30 17:43:23     tsctp-dbgsym_0.8.1-1_amd64.deb
2025/01/30 17:43:23     tsctp_0.8.1-1_amd64.deb
2025/01/30 17:43:24 Figuring out reverse build dependencies using dose-ceve(1).
This might take a while
2025/01/30 17:44:00 Found 0 reverse build dependencies
2025/01/30 17:44:00 Setting -sbuild_dist=unstable (from .changes file)
2025/01/30 17:44:00 Build results:


8. Install [No previous installs]: Good


9. Upgrade [Over previous installs if any]: Good


Additional...

A. Remove version from 'Build-Depends' 'libsctp-dev (>= 1.0.5)'. Oldest version
in Debian is old-old-stable which is version '1.0.18+dfsg-1'.

Summary...

I believe 'tsctp' is ready for review/possible sponsorship. Could a Debian
Developer (DD) with available free time, please review this package and upload
if you feel it is ready.


Please try the below on your packages...

[1] pbuilder:

  * Command for 1.: sudo pbuilder build <PACKAGE>.dsc
  * Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks


[2] sbuild:

  * Command: sbuild -d unstable <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild


[3] lintian:

  * Command: lintian --display-info --verbose --fail-on error --info --pedantic
--show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different
results, so be thorough.
  * Document: https://wiki.debian.org/Lintian


[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

  Note: Please report false positives as bug reports against 'licenserecon'

Reply via email to