Control: tags -1 +confirmed Ha6,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. This review is offered to help package contributors to Debian mentors improve their packages (where needed) prior to possible sponsorship into Debian by a Debian Developer. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Information only Running lintian... N: W: fdclone source: build-depends-on-obsolete-package Build-Depends: libncurses5-dev => libncurses-dev N: N: The package build-depends on a package that has been superseded. If the N: superseded package is part of an ORed group, it should not be the first N: package in the group. N: N: Visibility: warning N: Show-Always: no N: Check: fields/package-relations N: N: W: fdclone: groff-message troff:<standard input>:7: warning: macro 'an*section1' not defined [usr/share/man/ja/man1/fd.1.gz:1] N: N: A manual page provoked warnings or errors from the man program. Here are N: some common ones: N: N: "cannot adjust" or "can't break" are issues with paragraph filling. They N: are usually related to long lines. Justifying text on the left hand side N: can help with adjustments. Hyphenation can help with breaks. N: N: For more information, please see "Manipulating Filling and Adjusting" and N: "Manipulating Hyphenation" in the Groff manual (see info groff). N: N: "can't find numbered character" usually means that the input was in a N: national legacy encoding. The warning means that some characters were N: dropped. Please use escapes such as \[:a] as described on the groff_char N: manual page. N: N: Other common warnings are formatting typos. String arguments to .IP N: require quotes. Usually, some text is lost or mangled. See the groff_man N: (or groff_mdoc if using mdoc) manual page for details on macros. N: N: The check for manual pages uses the --warnings option to man to catch N: common problems, like a . or a ' at the beginning of a line as literal N: text. They are interpreted as Groff commands. Just reformat the paragraph N: so the characters are not at the beginning of a line. You can also add a N: zero-width space (\&) in front of them. N: N: Aside from overrides, warnings can be disabled with the .warn directive. N: Please see "Debugging" in the Groff manual. N: N: You can see the warnings yourself by running the command used by Lintian: N: N: LC_ALL=C.UTF-8 MANROFFSEQ='' MANWIDTH=80 \ N: man --warnings -E UTF-8 -l -Tutf8 -Z <file> >/dev/null N: N: Please refer to the groff_man(7) manual page and the groff_mdoc(7) manual N: page for details. N: N: Visibility: warning N: Show-Always: no N: Check: documentation/manual N: Renamed from: manpage-has-errors-from-man N: N: W: fdclone: groff-message troff:<standard input>:7: warning: macro 'an*section1' not defined [usr/share/man/ja/man1/fdsh.1.gz:1] N: I: fdclone: acute-accent-in-manual-page [usr/share/man/ja/man1/fd.1.gz:395] N: N: This manual page uses the \' groff sequence. Usually, the intent is to N: generate an apostrophe, but that sequence actually renders as an acute N: accent. N: N: For an apostrophe or a single closing quote, use plain '. For single N: opening quote, i.e. a straight downward line ' like the one used in shell N: commands, use '\(aq'. N: N: In case this tag was emitted for the second half of a '\\' sequence, this N: is indeed no acute accent, but still wrong: A literal backslash should be N: written \e in the groff format, i.e. a '\\' sequence needs to be changed N: to '\e' which also won't trigger this tag. N: N: Please refer to Bug#554897, Bug#507673, and Bug#966803 for details. N: N: Visibility: info N: Show-Always: no N: Check: documentation/manual N: Renamed from: acute-accent-in-manpage N: N: I: fdclone: acute-accent-in-manual-page [usr/share/man/ja/man1/fd.1.gz:476] N: I: fdclone: acute-accent-in-manual-page [usr/share/man/ja/man1/fd.1.gz:590] N: I: fdclone: acute-accent-in-manual-page [usr/share/man/ja/man1/fd.1.gz:803] N: I: fdclone: acute-accent-in-manual-page [usr/share/man/ja/man1/fdsh.1.gz:395] N: I: fdclone: acute-accent-in-manual-page [usr/share/man/ja/man1/fdsh.1.gz:476] N: I: fdclone: acute-accent-in-manual-page [usr/share/man/ja/man1/fdsh.1.gz:590] N: I: fdclone: acute-accent-in-manual-page [usr/share/man/ja/man1/fdsh.1.gz:803] N: I: fdclone source: debian-watch-uses-insecure-uri ftp://ftp.unixusers.net/src/fdclone/FD-(.*)\.tar\.gz [debian/watch:3] N: N: The watch file uses an unencrypted transport protocol for the URI such as N: http:// or ftp://. It is recommended to use a secure transport such as N: HTTPS for anonymous read-only access. N: N: Upstream may already provide a HTTPS variant of the URI. If not, please N: contact them and ask them to consider adding one. N: N: Visibility: info N: Show-Always: no N: Check: debian/watch N: N: I: fdclone source: older-debian-watch-file-standard 3 [debian/watch] N: N: The version= line in the debian/watch file in this package declares an N: older version. Please upgrade when you have a chance. N: N: Please refer to the uscan(1) manual page for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/watch/standard N: N: I: fdclone source: out-of-date-standards-version 4.6.1 (released 2022-05-11) (current is 4.7.0) N: N: The source package refers to a Standards-Version older than the one that N: was current at the time the package was created (according to the N: timestamp of the latest debian/changelog entry). Please consider updating N: the package to current Policy and setting this control field N: appropriately. N: N: If the package is already compliant with the current standards, you don't N: have to re-upload the package just to adjust the Standards-Version control N: field. However, please remember to update this field next time you upload N: the package. N: N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the N: debian-policy package for a summary of changes in newer versions of N: Policy. N: N: Please refer to N: https://www.debian.org/doc/debian-policy/upgrading-checklist.html for N: details. N: N: Visibility: info N: Show-Always: no N: Check: fields/standards-version N: N: I: fdclone source: patch-not-forwarded-upstream [debian/patches/40_Fix_GCC- 14_FTBFS_Closes_1074949.patch] N: N: According to the DEP-3 headers, this patch has not been forwarded N: upstream. N: N: Please forward the patch and try to have it included in upstream's version N: control system. If the patch is not suitable for that, please mention N: not-needed in the Forwarded field of the patch header. N: N: Please refer to social contract item 2, Coordination with upstream N: developers (Section 3.1.4) in the Debian Developer's Reference, Changes to N: the upstream sources (Section 4.3) in the Debian Policy Manual, and N: Bug#755153 for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/patches/dep3 N: Renamed from: send-patch N: N: P: fdclone source: maintainer-manual-page [debian/addition/fdsh.1] N: N: The maintainer keeps a manual page in ./debian. Please forward the manual N: page upstream and ask them to include in their version control system, and N: in their next release. N: N: If the manual page was already forwarded or rejected, or the upstream is N: gone, please override the tag and annotate it with a suitable comment. N: N: Please refer to social contract item 2, Coordination with upstream N: developers (Section 3.1.4) in the Debian Developer's Reference, and N: Changes to the upstream sources (Section 4.3) in the Debian Policy Manual N: for details. N: N: Visibility: pedantic N: Show-Always: no N: Check: debian/manual-pages N: Renamed from: maintainer-manpage N: E: Lintian run failed (runtime error) 3. Licenses [4]: Good 4. Watch file [uscan --force-download]: Issue, none blocking for NMU philwyett@ks-tarkin:~/Development/builder/debian/fdclone-3.01j$ uscan --force- download uscan warn: In debian/watch no matching files for watch line ftp://ftp.unixusers.net/src/fdclone/FD-(.*)\.tar\.gz 5. Build Twice (build source after successful build) [1]: Good 6. Reproducible builds [5]: Good Note: This test does not block sponsorship and is for information only at this time. It is good if a package passes this test. 7. Tail of the ratt (architecture dependant packages only) [6]: Good Note: This test does not block sponsorship and is for information only at this time. It is good if a package passes this test. philwyett@ks-tarkin:~/Development/builder/debian$ ratt --dist trixie fdclone_3.01j-1.1_amd64.changes 2025/01/30 14:11:27 Loading changes file "fdclone_3.01j-1.1_amd64.changes" 2025/01/30 14:11:27 - 2 binary packages: fdclone fdclone-dbgsym 2025/01/30 14:11:27 Corresponding .debs (will be injected when building): 2025/01/30 14:11:27 fdclone-dbgsym_3.01j-1.1_amd64.deb 2025/01/30 14:11:27 fdclone_3.01j-1.1_amd64.deb 2025/01/30 14:11:28 Figuring out reverse build dependencies using dose-ceve(1). This might take a while 2025/01/30 14:12:00 Found 0 reverse build dependencies 2025/01/30 14:12:00 Setting -sbuild_dist=unstable (from .changes file) 2025/01/30 14:12:00 Build results 8. Install [No previous installs]: Good 9. Upgrade [Over previous installs if any]: Good Summary... I believe 'fdclone' is ready for review/possible sponsorship. Could a Debian Developer (DD) with available free time, please review this package and upload if you feel it is ready. Some salvaging work needs to be done at a later date. Please try the below on your packages... [1] pbuilder: * Command for 1.: sudo pbuilder build <PACKAGE>.dsc * Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild -d unstable <PACKAGE>.dsc * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian --display-info --verbose --fail-on error --info --pedantic --show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon Note: Please report false positives as bug reports against 'licenserecon'
