Control: tags -1 +confirmed Lorenzo,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. This review is offered to help package contributors to Debian mentors improve their packages (where needed) prior to possible sponsorship into Debian by a Debian Developer. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Good 3. Licenses [4]: Information, none blocking I: runit source: invalid-dep3-format-patch-wrong-last-update [debian/patches/0026-Clean-up-at-the-end-of-rescan-test.patch] N: N: According to the DEP-3, the Last-Update field value should follow the ISO N: "YYYY-MM-DD" format. For example: Last-Update: 1999-12-31 N: N: Please refer to https://dep-team.pages.debian.net/deps/dep3/ for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/patches/dep3 N: N: I: runit source: patch-not-forwarded-upstream [debian/patches/0029-fix-ftbfs- with-gcc14.patch] N: N: According to the DEP-3 headers, this patch has not been forwarded N: upstream. N: N: Please forward the patch and try to have it included in upstream's version N: control system. If the patch is not suitable for that, please mention N: not-needed in the Forwarded field of the patch header. N: N: Please refer to social contract item 2, Coordination with upstream N: developers (Section 3.1.4) in the Debian Developer's Reference, Changes to N: the upstream sources (Section 4.3) in the Debian Policy Manual, and N: Bug#755153 for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/patches/dep3 N: Renamed from: send-patch 4. Watch file [uscan --force-download]: Good 5. Build Twice (build source after successful build) [1]: Good 6. Reproducible builds [5]: Not performed Note: This test does not block sponsorship and is for information only at this time. It is good if a package passes this test. 7. Tail of the ratt (architecture dependant packages only) [6]: Not performed Note: This test does not block sponsorship and is for information only at this time. It is good if a package passes this test. 8. Install [No previous installs]: Good 9. Upgrade [Over previous installs if any]: Good Summary... I believe 'runit' is ready for review/possible sponsorship. Could a Debian Developer (DD) with available free time, please review this package and upload if you feel it is ready. Please try the below on your packages... [1] pbuilder: * Command for 1.: sudo pbuilder build <PACKAGE>.dsc * Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild -d unstable <PACKAGE>.dsc * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian --display-info --verbose --fail-on error --info --pedantic --show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon Note: Please report false positives as bug reports against 'licenserecon'
