Control: tags -1 +confirmed

Loren,

Preamble...

Thank you for taking the time to prepare this package and your contribution to
the Debian project.

This review is offered to help package submitters to Debian mentors inorder to
improve their packages prior to possible sponsorship into Debian. There is no
obligation on behalf of the submitter to make any alterations based upon
information provided in the review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Issue, none block, but urgent work needed

Running lintian...
N:
W: gnucash-common: appstream-metadata-validation-failed Problems reported by
"appstreamcli validate-tree".
N: 
N:   The specified AppStream metadata file fail to validate using 'appstreamcli
N:   validate-tree --no-net path-to-package-root'.
N: 
N:   Please refer to https://wiki.debian.org/AppStream/Guidelines for details.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: appstream-metadata
N: 
N:
W: gnucash-common: national-encoding [usr/share/doc/gnucash-
common/examples/Money95bank_fr.qif]
N: 
N:   A file is not valid UTF-8.
N:   
N:   Debian has used UTF-8 for many years. Support for national encodings is
N:   being phased out. This file probably appears to users in mangled
N:   characters (also called mojibake).
N:   
N:   Packaging control files must be encoded in valid UTF-8.
N:   
N:   Please convert the file to UTF-8 using iconv or a similar tool.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: files/encoding
N:   Renamed from: national-encoding-in-text-file
N:   debian-changelog-file-uses-obsolete-national-encoding
N:   debian-control-file-uses-obsolete-national-encoding
N:   debian-copyright-file-uses-obsolete-national-encoding
N:   debian-news-file-uses-obsolete-national-encoding
N:   debian-tests-control-uses-national-encoding
N:   doc-base-file-uses-obsolete-national-encoding
N:   national-encoding-in-debconf-template national-encoding-in-manpage
N: 
N:
W: gnucash-common: national-encoding [usr/share/doc/gnucash-
common/examples/Money95invst_fr.qif]
N:
W: gnucash-common: national-encoding
[usr/share/gnucash/accounts/sk/acctchrt_brokerage.gnucash-xea]
N:
W: gnucash-common: national-encoding
[usr/share/gnucash/accounts/sk/acctchrt_carloan.gnucash-xea]
N:
W: gnucash-common: national-encoding
[usr/share/gnucash/accounts/sk/acctchrt_cdmoneymkt.gnucash-xea]
N:
W: gnucash-common: national-encoding
[usr/share/gnucash/accounts/sk/acctchrt_childcare.gnucash-xea]
N:
W: gnucash-common: national-encoding
[usr/share/gnucash/accounts/sk/acctchrt_common.gnucash-xea]
N:
W: gnucash-common: national-encoding
[usr/share/gnucash/accounts/sk/acctchrt_currency.gnucash-xea]
N:
W: gnucash-common: national-encoding
[usr/share/gnucash/accounts/sk/acctchrt_eduloan.gnucash-xea]
N:
W: gnucash-common: national-encoding
[usr/share/gnucash/accounts/sk/acctchrt_fixedassets.gnucash-xea]
N:
W: gnucash-common: national-encoding
[usr/share/gnucash/accounts/sk/acctchrt_homeloan.gnucash-xea]
N:
W: gnucash-common: national-encoding
[usr/share/gnucash/accounts/sk/acctchrt_homeown.gnucash-xea]
N:
W: gnucash-common: national-encoding
[usr/share/gnucash/accounts/sk/acctchrt_otherloan.gnucash-xea]
N:
W: gnucash-common: national-encoding
[usr/share/gnucash/accounts/sk/acctchrt_renter.gnucash-xea]
N:
W: gnucash-common: national-encoding
[usr/share/gnucash/accounts/sk/acctchrt_retiremt.gnucash-xea]
N:
W: gnucash-common: national-encoding
[usr/share/gnucash/accounts/sk/acctchrt_spouseinc.gnucash-xea]
N:
W: gnucash-common: national-encoding
[usr/share/gnucash/accounts/sk/acctchrt_spouseretire.gnucash-xea]
N:
W: gnucash-common: national-encoding
[usr/share/gnucash/accounts/tr_TR/acctchrt_cdmoneymkt.gnucash-xea]
N:
W: gnucash: no-manual-page [usr/bin/gnc-fq-update]
N: 
N:   Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should have
N:   a manual page
N:   
N:   Note that though the man program has the capability to check for several
N:   program names in the NAMES section, each of these programs should have its
N:   own manual page (a symbolic link to the appropriate manual page is
N:   sufficient) because other manual page viewers such as xman or tkman don't
N:   support this.
N:   
N:   If the name of the manual page differs from the binary by case, man may be
N:   able to find it anyway; however, it is still best practice to match the
N:   exact capitalization of the executable in the manual page.
N:   
N:   If the manual pages are provided by another package on which this package
N:   depends, Lintian may not be able to determine that manual pages are
N:   available. In this case, after confirming that all binaries do have manual
N:   pages after this package and its dependencies are installed, please add a
N:   Lintian override.
N: 
N:   Please refer to Manual pages (Section 12.1) in the Debian Policy Manual
N:   for details.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: documentation/manual
N:   Renamed from: binary-without-manpage
N: 
N:
W: gnucash-common: script-not-executable
[usr/share/gnucash/python/pycons/pycons]
N: 
N:   This file starts with the #! sequence that marks interpreted scripts, but
N:   it is not executable.
N:   
N:   There has been some discussion to allow such files in paths other than
N:   /usr/bin but there was ultimately no broad support for it.
N: 
N:   Please refer to Bug#368792 for details.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: scripts
N: 
N:
W: gnucash source: superfluous-file-pattern gnucash/gnome-utils/gnc-currency-
edit.c [debian/copyright:189]
N: 
N:   The wildcard that was specified matches no file in the source tree. This
N:   either indicates that you should fix the wildcard so that it matches the
N:   intended file or that you can remove the wildcard. Notice that in contrast
N:   to shell globs, the "*" (star or asterisk) matches slashes and leading
N:   dots.
N: 
N:   Please refer to
N:   https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for
N:   details.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: debian/copyright/dep5
N: 
N:
W: gnucash source: superfluous-file-pattern gnucash/gnome-utils/gnc-date-
delta.c [debian/copyright:189]
N:
W: gnucash source: superfluous-file-pattern gnucash/gnome-utils/gnc-date-
delta.h [debian/copyright:189]
N:
W: gnucash source: superfluous-file-pattern gnucash/gnome/dialog-sx-editor2.c
[debian/copyright:165]
N:
W: gnucash source: superfluous-file-pattern gnucash/gnome/dialog-sx-editor2.h
[debian/copyright:150]
N:
W: gnucash source: superfluous-file-pattern gnucash/gnome/gnc-plugin-page-sx-
list.c [debian/copyright:165]
N:
W: gnucash source: superfluous-file-pattern libgnucash/app-utils/gnc-
accounting-period.c [debian/copyright:189]
N:
W: gnucash source: superfluous-file-pattern libgnucash/app-utils/gnc-
accounting-period.h [debian/copyright:189]
N:
W: gnucash source: superfluous-file-pattern libgnucash/core-utils/gnc-jalali.c
[debian/copyright:220]
N:
W: gnucash source: superfluous-file-pattern libgnucash/doc/design/gnucash-
design.info [debian/copyright:142]
N:
W: gnucash source: superfluous-file-pattern libgnucash/doc/design/gnucash-
design.texi [debian/copyright:142]
N:
W: gnucash-common: unusual-interpreter python
[usr/share/gnucash/python/pycons/__init__.py]
N: 
N:   This package contains a script for an interpreter that is not shipped in
N:   the package and is not known to Lintian. It is possible that there is a
N:   typo or the interpreter is not executable.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: scripts
N: 
N:
W: gnucash-common: unusual-interpreter python
[usr/share/gnucash/python/pycons/pycons]
N:
W: gnucash-common: unusual-interpreter python
[usr/share/gnucash/python/pycons/setup.py]
N:
W: gnucash-common: unusual-interpreter python
[usr/share/gnucash/python/pycons/simple_plot.py]
N:
I: gnucash: desktop-entry-lacks-keywords-entry
[usr/share/applications/gnucash.desktop]
N: 
N:   This .desktop file is either missing a Keywords entry, or it does not
N:   contain keywords above and beyond those already present in the Name or
N:   GenericName entries.
N:   
N:   The Keywords field is intended to show keywords relevant for a .desktop
N:   file.
N:   
N:   Desktop files are organized in key-value pairs and are similar to INI
N:   files.
N:   
N:   The desktop-file-validate tool in the desktop-file-utils package may be
N:   useful when checking the syntax of desktop entries.
N: 
N:   Please refer to
N:  
https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html,
N:   Bug#693918, and
N:   https://wiki.gnome.org/Initiatives/GnomeGoals/DesktopFileKeywords for
N:   details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: menu-format
N: 
N:
I: gnucash: extra-license-file [usr/share/doc/gnucash/LICENSE]
N: 
N:   All license information should be collected in the debian/copyright file.
N:   This usually makes it unnecessary for the package to install this
N:   information in other places as well.
N: 
N:   Please refer to Copyright information (Section 12.5) in the Debian Policy
N:   Manual for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: files/licenses
N: 
N:
I: gnucash source: out-of-date-standards-version 4.6.2 (released 2022-12-17)
(current is 4.7.0)
N: 
N:   The source package refers to a Standards-Version older than the one that
N:   was current at the time the package was created (according to the
N:   timestamp of the latest debian/changelog entry). Please consider updating
N:   the package to current Policy and setting this control field
N:   appropriately.
N:   
N:   If the package is already compliant with the current standards, you don't
N:   have to re-upload the package just to adjust the Standards-Version control
N:   field. However, please remember to update this field next time you upload
N:   the package.
N:   
N:   See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N:   debian-policy package for a summary of changes in newer versions of
N:   Policy.
N: 
N:   Please refer to
N:   https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
N:   details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: fields/standards-version
N: 
N:
I: gnucash: spelling-error-in-binary Charactors Characters [usr/lib/x86_64-
linux-gnu/gnucash/gnucash/libgnc-gnome-utils.so]
N: 
N:   Lintian found a spelling error in the given binary. Lintian has a list of
N:   common misspellings that it looks for. It does not have a dictionary like
N:   a spelling checker does.
N:   
N:   If the string containing the spelling error is translated with the help of
N:   gettext or a similar tool, please fix the error in the translations as
N:   well as the English text to avoid making the translations fuzzy. With
N:   gettext, for example, this means you should also fix the spelling mistake
N:   in the corresponding msgids in the *.po files.
N:   
N:   You can often find the word in the source code by running:
N:   
N:    grep -rw <word> <source-tree>
N:   
N:   This tag may produce false positives for words that contain non-ASCII
N:   characters due to limitations in strings.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: binaries/spelling
N: 
N:
I: gnucash: spelling-error-in-binary brige bridge [usr/lib/x86_64-linux-
gnu/guile/3.0/site-ccache/gnucash/locale/de_DE/tax/txf-help.go]
N:
I: gnucash: spelling-error-in-binary brige bridge [usr/lib/x86_64-linux-
gnu/guile/3.0/site-ccache/gnucash/locale/de_DE/tax/txf.go]
N:
I: gnucash: spelling-error-in-binary nam name [usr/lib/x86_64-linux-
gnu/gnucash/libgnc-gnome.so]
N:
I: gnucash: spelling-error-in-binary ofthe of the [usr/lib/x86_64-linux-
gnu/gnucash/libgnc-engine.so]
N:
I: gnucash: spelling-error-in-binary registerd registered [usr/lib/x86_64-
linux-gnu/gnucash/libgnc-engine.so]
N:
I: gnucash: spelling-error-in-binary secion section [usr/lib/x86_64-linux-
gnu/gnucash/libgnc-engine.so]
N:
I: gnucash source: uses-deprecated-python-stdlib distutils (deprecated in
Python 3.10, removed in Python 3.12) [gnucash/python/pycons/setup.py:29]
N: 
N:   
N:   The Python library flagged by this tag has been formally marked as
N:   deprecated.
N:   
N:   Please prepare for this deprecation and migrate away from this Python
N:   library.
N:   
N:   See-Also: https://peps.python.org/pep-0594/#deprecated-modules
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: languages/python/stdlib-deprecation
N: 
N:
P: gnucash source: debug-symbol-migration-possibly-complete --dbgsym-
migration='gnucash-dbg (<< 1:2.6.13~)' [debian/rules:109]
N: 
N:   The debian/rules file for this package has a call to dh_strip(1) with the
N:   specified --dbgsym-migration or --ddeb-migration argument.
N:   
N:   Such arguments are used to migrate packages to use automatic debug
N:   symbols, which first became available in December 2015.
N:   
N:   If this command was added to the debian/rules that was included in the
N:   current stable release of Debian then it can possibly be removed.
N:   
N:   However, if the command was added later (and/or the package was not
N:   included in stretch) please wait until it has been included in a stable
N:   release before removing it.
N: 
N:   Please refer to the dh_strip(1) manual page and
N:   https://wiki.debian.org/AutomaticDebugPackages for details.
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: debian/rules
N: 
N:
P: gnucash source: package-uses-old-debhelper-compat-version 12
N: 
N:   This package uses a debhelper compatibility level that is no longer
N:   recommended. Please consider using the recommended level.
N:   
N:   For most packages, the best way to set the compatibility level is to
N:   specify debhelper-compat (= X) as a Build-Depends in debian/control. You
N:   can also use the debian/compat file or export DH_COMPAT in debian/rules.
N:   
N:   If no level is selected debhelper defaults to level 1, which is
N:   deprecated.
N: 
N:   Please refer to the debhelper(7) manual page for details.
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: debhelper
N: 
N:
P: gnucash: repeated-path-segment gnucash [usr/lib/x86_64-linux-
gnu/gnucash/gnucash/]
N: 
N:   The file is installed into a location that repeats the given path segment.
N:   An example would be /usr/lib/lib or /usr/share/myprogram/share.
N:   
N:   More often than not this is unintended.
N: 
N:   Please refer to Bug#950052 and Bug#950027 for details.
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: files/hierarchy/path-segments
N: 
N:
P: gnucash: repeated-path-segment gnucash [usr/lib/x86_64-linux-
gnu/guile/3.0/site-ccache/gnucash/deprecated/gnucash/]
N:
P: gnucash: repeated-path-segment gnucash
[usr/share/guile/site/3.0/gnucash/deprecated/gnucash/]
N:
P: gnucash source: source-contains-prebuilt-javascript-object
[borrowed/chartjs/Chart.bundle.js]
N: 
N:   The source tarball contains a prebuilt (minified) JavaScript object. They
N:   are usually left by mistake when generating the tarball by not cleaning
N:   the source directory first. You may want to report this as an upstream
N:   bug, in case there is no sign that this was intended.
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: files/source-missing
N: 
N:
P: gnucash source: source-contains-prebuilt-javascript-object
[borrowed/chartjs/Chart.bundle.min.js]
N:
P: gnucash source: source-contains-prebuilt-javascript-object
[borrowed/chartjs/Chart.js]
N:
P: gnucash source: source-contains-prebuilt-javascript-object
[borrowed/chartjs/Chart.min.js]
N:
O: gnucash: hardening-no-fortify-functions [usr/lib/x86_64-linux-
gnu/gnucash/gnucash/libgnc-bi-import.so]
N: 
N:   This package provides an ELF binary that lacks the use of fortified libc
N:   functions. Either there are no potentially unfortified functions called by
N:   any routines, all unfortified calls have already been fully validated at
N:   compile-time, or the package was not built with the default Debian
N:   compiler flags defined by dpkg-buildflags. If built using dpkg-buildflags
N:   directly, be sure to import CPPFLAGS.
N:   
N:   NB: Due to false-positives, Lintian ignores some unprotected functions
N:   (e.g. memcpy).
N: 
N:   Please refer to https://wiki.debian.org/Hardening and Bug#673112 for
N:   details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: binaries/hardening
N: 
N:
O: gnucash: hardening-no-fortify-functions [usr/lib/x86_64-linux-
gnu/gnucash/gnucash/libgnc-log-replay.so]
N:
O: gnucash: hardening-no-fortify-functions [usr/lib/x86_64-linux-
gnu/gnucash/gnucash/libgncmod-aqbanking.so]
N:
O: gnucash: hardening-no-fortify-functions [usr/lib/x86_64-linux-
gnu/gnucash/gnucash/libgncmod-backend-dbi.so]
N:
O: gnucash: hardening-no-fortify-functions [usr/lib/x86_64-linux-
gnu/gnucash/libgnc-backend-sql.so]

E: Lintian run failed (runtime error)

3. Licenses [4]: Issue, none blocking but urgent work required

4. Watch file [uscan --force-download]: Good

5. Build Twice (build source after successful build [1]: Good

6. Reproducible builds [5]: Issue, none blocking

130/130 Testing: python-bindings
130/130 Test: python-bindings
Command: "/usr/bin/python3"
"/tmp/reprotest.Tr9VJz/const_build_path/const_build_path/bindings/python/tests/
runTests.py.in"
Directory:
/tmp/reprotest.Tr9VJz/const_build_path/const_build_path/.build/bindings/python/
tests
"python-bindings" start time: Jan 15 04:34 GMT
Output:
----------------------------------------------------------
* 04:34:09  WARN <gnc.core-utils> no preferences backend loaded, or the backend
doesn't define register_cb, returning 0
* 04:34:09  WARN <gnc.core-utils> no preferences backend loaded, or the backend
doesn't define register_cb, returning 0
* 04:34:09  WARN <gnc.core-utils> no preferences backend loaded, or the backend
doesn't define register_cb, returning 0
* 04:34:09  WARN <gnc.core-utils> no preferences backend loaded, or the backend
doesn't define register_cb, returning 0
* 04:34:09  WARN <gnc.core-utils> no preferences backend loaded, or the backend
doesn't define register_cb, returning 0
........F........................./tmp/reprotest.Tr9VJz/const_build_path/const_
build_path/bindings/python/tests/test_session.py:26: DeprecationWarning: Use of
ignore_lock, is_new or force_new arguments is deprecated. Use mode argument
instead. Have a look at gnucash.SessionOpenMode.
  self.ses = Session(ignore_lock=False, is_new=True, force_new=False)
..* 04:34:10  WARN <gnc.backend> [GncXmlBackend::check_path()] Couldn't find
/tmp/tmptcld5ho3/tempfile2
/tmp/reprotest.Tr9VJz/const_build_path/const_build_path/bindings/python/tests/t
est_session.py:52: DeprecationWarning: Use of ignore_lock, is_new or force_new
arguments is deprecated. Use mode argument instead. Have a look at
gnucash.SessionOpenMode.
  ses.begin(uri, is_new=False)
* 04:34:10  WARN <gnc.backend> [GncXmlBackend::check_path()] Couldn't find
/tmp/tmptcld5ho3/tempfile2
/tmp/reprotest.Tr9VJz/const_build_path/const_build_path/bindings/python/tests/t
est_session.py:61: DeprecationWarning: Use of ignore_lock, is_new or force_new
arguments is deprecated. Use mode argument instead. Have a look at
gnucash.SessionOpenMode.
  ses.begin(uri, is_new=True)
..* 04:34:10 ERROR <gnc.engine.scrub> [xaccTransScrubSplits()] Transaction
doesn't have a currency!
* 04:34:10 ERROR <gnc.engine.scrub> void TransScrubOrphansFast(Transaction*,
Account*): assertion 'trans && trans->common_currency && root' failed
.....F...........
======================================================================
FAIL: test_post (test_business.TestBusiness.test_post)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/tmp/reprotest.Tr9VJz/const_build_path/const_build_path/bindings/python/tests/
test_business.py", line 66, in test_post
    self.assertEqual(neutral_time,
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
                     self.invoice.GetDatePosted().astimezone(timezone.utc))
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: datetime.datetime(2025, 1, 15, 12, 59,
tzinfo=datetime.timezone.utc) != datetime.datetime(2025, 1, 16, 10, 59,
tzinfo=datetime.timezone.utc)

======================================================================
FAIL: test_date (test_transaction.TestTransaction.test_date)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/tmp/reprotest.Tr9VJz/const_build_path/const_build_path/bindings/python/tests/
test_transaction.py", line 136, in test_date
    self.assertEqual(ZERODATE, self.trans.GetDate().astimezone(timezone.utc))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: datetime.datetime(1970, 1, 1, 0, 0,
tzinfo=datetime.timezone.utc) != datetime.datetime(1970, 1, 2, 0, 0,
tzinfo=datetime.timezone.utc)

----------------------------------------------------------------------
Ran 55 tests in 0.026s

FAILED (failures=2)
<CRITICAL> (gnc.engine.scrub) [xaccTransScrubSplits()] Transaction doesn't have
a currency!
<CRITICAL> (gnc.engine.scrub) void TransScrubOrphansFast(Transaction*,
Account*): assertion 'trans && trans->common_currency && root' failed
<CRITICAL> (gnc.engine.scrub) [xaccTransScrubSplits()] Transaction doesn't have
a currency!
<CRITICAL> (gnc.engine.scrub) void TransScrubOrphansFast(Transaction*,
Account*): assertion 'trans && trans->common_currency && root' failed
<CRITICAL> (gnc.engine.scrub) [xaccTransScrubSplits()] Transaction doesn't have
a currency!
<CRITICAL> (gnc.engine.scrub) void TransScrubOrphansFast(Transaction*,
Account*): assertion 'trans && trans->common_currency && root' failed
<CRITICAL> (gnc.engine.scrub) [xaccTransScrubSplits()] Transaction doesn't have
a currency!
<CRITICAL> (gnc.engine.scrub) void TransScrubOrphansFast(Transaction*,
Account*): assertion 'trans && trans->common_currency && root' failed
<CRITICAL> (gnc.engine.scrub) [xaccTransScrubSplits()] Transaction doesn't have
a currency!
<CRITICAL> (gnc.engine.scrub) void TransScrubOrphansFast(Transaction*,
Account*): assertion 'trans && trans->common_currency && root' failed
<CRITICAL> (gnc.engine.scrub) [xaccTransScrubSplits()] Transaction doesn't have
a currency!
<CRITICAL> (gnc.engine.scrub) void TransScrubOrphansFast(Transaction*,
Account*): assertion 'trans && trans->common_currency && root' failed
<CRITICAL> (gnc.engine.scrub) [xaccTransScrubSplits()] Transaction doesn't have
a currency!
<CRITICAL> (gnc.engine.scrub) void TransScrubOrphansFast(Transaction*,
Account*): assertion 'trans && trans->common_currency && root' failed
<CRITICAL> (gnc.engine.scrub) [xaccTransScrubSplits()] Transaction doesn't have
a currency!
<CRITICAL> (gnc.engine.scrub) void TransScrubOrphansFast(Transaction*,
Account*): assertion 'trans && trans->common_currency && root' failed
<CRITICAL> (gnc.engine.scrub) [xaccTransScrubSplits()] Transaction doesn't have
a currency!
<CRITICAL> (gnc.engine.scrub) void TransScrubOrphansFast(Transaction*,
Account*): assertion 'trans && trans->common_currency && root' failed
<CRITICAL> (gnc.engine.scrub) [xaccTransScrubSplits()] Transaction doesn't have
a currency!
<CRITICAL> (gnc.engine.scrub) void TransScrubOrphansFast(Transaction*,
Account*): assertion 'trans && trans->common_currency && root' failed
<CRITICAL> (gnc.engine.scrub) [xaccTransScrubSplits()] Transaction doesn't have
a currency!
<CRITICAL> (gnc.engine.scrub) void TransScrubOrphansFast(Transaction*,
Account*): assertion 'trans && trans->common_currency && root' failed
<CRITICAL> (gnc.engine.scrub) [xaccTransScrubSplits()] Transaction doesn't have
a currency!
<CRITICAL> (gnc.engine.scrub) void TransScrubOrphansFast(Transaction*,
Account*): assertion 'trans && trans->common_currency && root' failed
<CRITICAL> (gnc.engine.scrub) [xaccTransScrubSplits()] Transaction doesn't have
a currency!
<CRITICAL> (gnc.engine.scrub) void TransScrubOrphansFast(Transaction*,
Account*): assertion 'trans && trans->common_currency && root' failed
<CRITICAL> (gnc.engine.scrub) [xaccTransScrubSplits()] Transaction doesn't have
a currency!
<CRITICAL> (gnc.engine.scrub) void TransScrubOrphansFast(Transaction*,
Account*): assertion 'trans && trans->common_currency && root' failed
<CRITICAL> (gnc.engine.scrub) [xaccTransScrubSplits()] Transaction doesn't have
a currency!
<CRITICAL> (gnc.engine.scrub) void TransScrubOrphansFast(Transaction*,
Account*): assertion 'trans && trans->common_currency && root' failed
<sys>:0: DeprecationWarning: builtin type swigvarlink has no __module__
attribute
<end of output>
Test time =   0.13 sec
----------------------------------------------------------
Test Failed.
"python-bindings" end time: Jan 15 04:34 GMT
"python-bindings" time elapsed: 00:00:00
----------------------------------------------------------

End testing: Jan 15 04:34 GMT
+ exit 2
make[1]: *** [debian/rules:97: override_dh_auto_test] Error 2
make[1]: Leaving directory
'/tmp/reprotest.Tr9VJz/const_build_path/const_build_path'
make: *** [debian/rules:33: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/reprotest/__init__.py", line 862, in run
    return 0 if check_func(*check_args) else 1
                ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/reprotest/__init__.py", line 410, in
check_auto
    dist_x0 = proc.send(("control", var_x0))
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/reprotest/__init__.py", line 339, in
corun_builds
    bctx.run_build(testbed, build, os.environ, artifact_pattern,
testbed_build_pre, no_clean_on_error)
  File "/usr/lib/python3/dist-packages/reprotest/__init__.py", line 218, in
run_build
    testbed.check_exec2(build_argv,
  File "/usr/lib/python3/dist-packages/reprotest/__init__.py", line 63, in
check_exec2
    self.bomb('"%s" failed with status %i' % (' '.join(argv), code),
  File "/usr/lib/python3/dist-packages/reprotest/__init__.py", line 70, in bomb
    raise _type(m)
reprotest.lib.adtlog.AutopkgtestError: "su -p -s /bin/sh root -c set -e; export
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin; run_build()
{
    mkdir -p /tmp/reprotest.Tr9VJz/build-control-aux && \
    mv /tmp/reprotest.Tr9VJz/build-control/
/tmp/reprotest.Tr9VJz/const_build_path && \
    SETARCH_ARCH=$(uname -m) && \
    SETARCH_OPTS="$SETARCH_OPTS -R" && \
    CPU_MAX=$(nproc) && \
    CPU_MIN=$({ echo $CPU_MAX; echo 1; } | sort -n | head -n1) && \
    CPU_NUM=$CPU_MIN && \
    export CPU_LIST="$(echo $(shuf -i0-$((CPU_MAX - 1)) -n$CPU_NUM) | tr ' '
,)" && \
    umask 0022 && \
    export REPROTEST_BUILD_PATH=/tmp/reprotest.Tr9VJz/const_build_path/ && \
    export REPROTEST_UMASK=$(umask) && \
    taskset -a -c $CPU_LIST \
    setarch $SETARCH_ARCH $SETARCH_OPTS \
    sh -ec 'cd "$REPROTEST_BUILD_PATH"; unset REPROTEST_BUILD_PATH; umask
"$REPROTEST_UMASK"; unset REPROTEST_UMASK; dpkg-source -x "gnucash_5.10-
0.1.dsc" "$(basename "$PWD")" && cd "$(basename "$PWD")" && dpkg-buildpackage -
-no-sign -b'
}

cleanup() {
    __c=0; \
    mv /tmp/reprotest.Tr9VJz/const_build_path /tmp/reprotest.Tr9VJz/build-
control/ || __c=$?; \
    rm -rf /tmp/reprotest.Tr9VJz/build-control-aux || __c=$?; \
    exit $__c
}

trap '( cleanup )' HUP INT QUIT ABRT TERM PIPE # FIXME doesn't quite work
reliably yet

if ( run_build ); then ( cleanup ); else
    __x=$?; # save the exit code of run_build
    if ( ! false ); then
        if ( cleanup ); then :; else echo >&2 "cleanup failed with exit code
$?"; fi;
    fi
    exit $__x
fi" failed with status 2

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: Good

Summary...

Nice work Loren.

I am happy to let this go through, but the package does a lot of
work/salvaging.

I believe 'gnucash' is ready for review/possible sponsorship. Could a Debian
Developer (DD) with available free time, please review this package and upload
if you feel it is ready.

Please try the below on your packages...

[1] pbuilder:

  * Command for 1.: sudo pbuilder build <PACKAGE>.dsc
  * Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild -d unstable <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian --display-info --verbose --fail-on error --info --pedantic
--show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different
results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

  Note: Please report false positives as bug reports against 'licenserecon'

Reply via email to