Control: tags -1 -confirmed
Control: tags -1 +moreinfo

Raul,

A fresh review for the 2025-01-08 19:11 upload.

Preamble...

Thank you for taking the time to prepare this package and your contribution to
the Debian project.

This review is offered to help package submitters to Debian mentors inorder to
improve their packages prior to possible sponsorship into Debian. There is no
obligation on behalf of the submitter to make any alterations based upon
information provided in the review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Good

3. Licenses [4]: Issue

philwyett@ks-tarkin:~/Development/builder/debian/boost-ext-ut-2.1.1$ lrc
en: Versions: recon 3.3  check 3.3.9-1

Parsing Source Tree  ....
Reading d/copyright  ....
** Superfluous file pattern cmake/PackageProject.cmake
Running licensecheck ....

The file highlighted is one you remove via the patch listed below.

'd/patches/arch-indep.patch'

This file highlishted now does not need to be in 'd/copyright'.

I would suggest exploring removal of this and other files in the above
mentioned patch via the 'Files-Excluded' mechanism.

https://wiki.debian.org/UscanEnhancements

4. Watch file [uscan --force-download]: Good

5. Build Twice (build source after successful build [1]: Good

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: N/A

Summary...

I believe 'boost-ext-ut' is not yet ready for sponsorship at this time. Could
the contributor rectify one of more of the raised issues.

Once updated to your satisfaction and a new upload done, please remove the
'moreinfo' tag on the Request For Sponsorship (RFS) bug report.

To remove 'moreinfo' tag, add below line to top of email replying to bug report
when a new upload is made.

Control: tags -1 -moreinfo

Please try the below on your packages...

[1] pbuilder:

  * Command for 1.: sudo pbuilder build <PACKAGE>.dsc
  * Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild -d unstable <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian --display-info --verbose --fail-on error --info --pedantic
--show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different
results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

  Note: Please report false positives as bug reports against 'licenserecon'

Reply via email to